add an env_with_source function to Arg #5569
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a527836
to
315c2ff
Compare
This is intended to resolve clap-rs#4607, and also my earlier request clap-rs#5104 which was closed in favor of clap-rs#4607 This is obviously not as powerful as the plugin system envisioned here clap-rs#4607 (comment) but it is simple and might be a useful stopgap until such time as the plugin system exists. Fixes clap-rs#4607
|
#4607 is marked as "S-waiting-on-design", meaning there isn't an agreed to design for it to move forward. As this is still in the design discussion phase, a PR feels premature. As such, I'm going to close this so we keep the focus on the design discussion there, rather than forking that conversation here or getting distracted with implementation discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to resolve #4607, and also my earlier request #5104 which was closed in favor of #4607
This is obviously not as powerful as the plugin system envisioned here #4607 (comment)
but it is simple and might be a useful stopgap until such time as the plugin system exists.
It doesn’t go as far as 5104 wanted but it’s still pretty useful imo.
Fixes #4607
feedback on the approach would be appreciated