Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add options to getData() and DataController#get() #7628

Closed
Reinmar opened this issue Jul 15, 2020 · 0 comments · Fixed by #7773
Closed

Add options to getData() and DataController#get() #7628

Reinmar opened this issue Jul 15, 2020 · 0 comments · Fixed by #7773
Assignees
@oskarwrobel
Labels
squad:collaboration Issue to be handled by the Collaboration team. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone
iteration 35 (v22...

Comments

@Reinmar
Copy link
Member

Reinmar commented Jul 15, 2020

📝 Provide a description of the new feature

There are scenarios in which, besides the default content returned/accepted by get/setData() we want to output an alternative form of the content. E.g. with previews of some media or without user suggestions.

The options passed to these methods should be available throughout the upcast conversion of all type of nodes (elements and text nodes and document fragments).

If you'd like to see this feature implemented, add a 👍 reaction to this post.
@Reinmar Reinmar added type:feature This issue reports a feature request (an idea for a new functionality or a missing option). squad:collaboration Issue to be handled by the Collaboration team. labels Jul 15, 2020
@Reinmar Reinmar added this to the nice-to-have milestone Jul 15, 2020
@scofalik scofalik changed the title Add options to getData() and DataProcessor#get() Add options to getData() and DataController#get() Aug 3, 2020
This was referenced Aug 4, 2020
Merged
Closed
scofalik added a commit that referenced this issue Aug 10, 2020
@scofalik
Merge pull request #7773 from ckeditor/t/7628
0a5d07e 
Feature (engine): Options set in `Editor#getData()` and `DataController#get()` are now available in downcast conversion under `conversionApi.options` object. Closes #7628.
@Reinmar Reinmar modified the milestones: nice-to-have, iteration 35 Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oskarwrobel oskarwrobel

Labels
squad:collaboration Issue to be handled by the Collaboration team. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
iteration 35 (v22.0.0)
Development

Successfully merging a pull request may close this issue.

Introduced additional conversion options for downcast conversion. ckeditor/ckeditor5
2 participants
@Reinmar @oskarwrobel