Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the selection handler #4586

Closed
oleq opened this issue May 30, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-widget#43
Closed

Implement the selection handler #4586

oleq opened this issue May 30, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-widget#43
Assignees
@jodator
Labels
package:widget type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone
iteration 19

Comments

@oleq
Copy link
Member

oleq commented May 30, 2018

A follow-up of https://github.com/ckeditor/ckeditor5-table/issues/1#issuecomment-392034926.

  1. The selection handler will be enabled by default for the table widget only because it needs it badly due to a quirky geometry of the table and lack of space to select it (no handler for the image widget ATM). In the MVP, the widget must explicitly enable this feature.
  2. The design looks as follows
    image
  3. Later on, this will become a drag&drop handler as the proper support is implemented.
@jodator jodator self-assigned this Jun 18, 2018
oleq referenced this issue in ckeditor/ckeditor5-widget Jun 27, 2018
@oleq
Merge pull request #43 from ckeditor/t/40
bbf9298 
Feature: Implemented the widget selection handler. Closes #40.
oleq referenced this issue in ckeditor/ckeditor5-theme-lark Jun 27, 2018
@oleq
Merge pull request #184 from ckeditor/t/ckeditor5-widget/40
0703b2b 
Feature: Implemented styles for the widget selection handler (see ckeditor/ckeditor5-widget#40). 

Also fixed a regression after ckeditor/ckeditor5#936 which made the widget use wrong outline styles when the editable is blurred. Minor code refactoring in the widget styles.

BREAKING CHANGE: Several `--ck-color-widget-*` custom properties have been renamed to match the project's naming standards.
oleq referenced this issue in ckeditor/ckeditor5-table Jun 27, 2018
@oleq
Merge pull request #79 from ckeditor/t/ckeditor5-widget/40
47295bd 
Feature: Implemented and enabled the table selection handler (see ckeditor/ckeditor5-widget#40).
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-widget Oct 9, 2019
@mlewand mlewand added this to the iteration 19 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:widget labels Oct 9, 2019
This was referenced Oct 11, 2019
Merged
Merged
@jodator jodator mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodator jodator

Labels
package:widget type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
iteration 19
Development

Successfully merging a pull request may close this issue.

T/40: Implement the selection handler ckeditor/ckeditor5-widget
3 participants
@jodator @oleq @mlewand