Non printable keys like volume up remove the content

[mlewand]

Are you reporting a feature request or a bug?

Bug

Provide detailed reproduction steps (if any)

1. Open CKEditor 5 instance with typing plugin, e.g. classic editor demo.
2. Select some text.
3. Use volume up button.

Expected result

Text is not removed.

Actual result

Text is removed.

Other details

Other examples keys like:

• Menu key
• Play/Pause, Rewind (other media buttons)
• Insert Key
• Num lock

---

• Browser: All
• OS: Win10

[jodator]

I can confirm the same issue on Linux Mint 18.3 Cinnamon, browsers checked: Chrome & Firefox.

For me, the buttons that causes the bug are:

• menu
• home
• scroll lock
• pause/break
• num lock
• enable/disable touchpad
• enable/disable monitor backlight

Buttons that do not cause the bug:

• media buttons (play, volume +/-, mute)
• email
• calculator
• print screen
• brightness up/down
• keyboard brightness up/down

[Reinmar]

We need to hardcode so-called "safe keys", unfortunately. You can find them in https://github.com/ckeditor/ckeditor5-typing/blob/a02eab5f73bf2c0288a7149b34424c1badbc380a/src/input.js#L312-L328 and this list isn't complete yet. Actually, I don't think that it ever will be, but fortunately, it's not a critical problem.

[Reinmar]

A DUP with some more keys reported in #955.

[pomek]

Referring to #955 - Windows key does not change anything in the editor. It even isn't caught by the observer.

[Reinmar]

Referring to ckeditor/ckeditor5#955 - Windows key does not change anything in the editor. It even isn't caught by the observer.

Are you sure this is true on all browsers on all platforms?

[pomek]

No. I don't remember do I check it on Edge (Win 10).

[Reinmar]

Because we can easily add the win key and other keys we know are safe to the "safe keys" object and just be future proof. Assuming anything here would have to be backed by serious proofs. Especially that issue like the one with the win key were already reported.