Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Commit

Permalink
Merge pull request #103 from ckeditor/t/ckeditor5/742
Browse files Browse the repository at this point in the history
Other: Aligned `ElementDefinition` usage to the changes in the engine. See ckeditor/ckeditor5#742.

BREAKING CHANGES: In the custom format of the heading feature configuration the `view.style`, `view.class` and `view.attribute` properties are now called `view.styles`, `view.classes` and `view.attributes`.
  • Loading branch information
Reinmar committed Apr 5, 2018
2 parents 237ab8e + 9d4be50 commit 96d24f4
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion docs/_snippets/features/custom-heading-elements.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ ClassicEditor
model: 'headingFancy',
view: {
name: 'h2',
class: 'fancy'
classes: 'fancy'
},
title: 'Heading 2 (fancy)',
class: 'ck-heading_heading2_fancy',
Expand Down
2 changes: 1 addition & 1 deletion docs/features/headings.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ ClassicEditor
model: 'headingFancy',
view: {
name: 'h2',
class: 'fancy'
classes: 'fancy'
},
title: 'Heading 2 (fancy)',
class: 'ck-heading_heading2_fancy',
Expand Down
2 changes: 1 addition & 1 deletion tests/headingediting.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ describe( 'HeadingEditing', () => {
model: 'heading1',
view: 'h1',
upcastAlso: [
{ name: 'p', attribute: { 'data-heading': 'h1' } }
{ name: 'p', attributes: { 'data-heading': 'h1' } }
],
title: 'User H1',
priority: 'high'
Expand Down
2 changes: 1 addition & 1 deletion tests/integration.js
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ describe( 'Heading integration', () => {
model: 'headingFancy',
view: {
name: 'h2',
class: 'fancy'
classes: 'fancy'
},
title: 'Heading 2 (fancy)',
class: 'ck-heading_heading2_fancy',
Expand Down

0 comments on commit 96d24f4

Please sign in to comment.