Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page elements scroll when view's DomConverter focuses an editable #4072

Closed
oleq opened this issue May 17, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-engine#958
Closed

Page elements scroll when view's DomConverter focuses an editable #4072

oleq opened this issue May 17, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-engine#958
Assignees
@oleq
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 11

Comments

@oleq
Copy link
Member

oleq commented May 17, 2017

A follow-up https://github.com/ckeditor/ckeditor5-engine/issues/951.

It turned out that we need to extend the fix to consider all elements, starting from the editable up to the window. It's basically the #4068 on steroids.
@oleq oleq self-assigned this May 17, 2017
oleq referenced this issue in ckeditor/ckeditor5-engine May 17, 2017
@oleq
Fix: None of the editable's ancestors should scroll when the DomConve…
a61e847 
…rter focuses an editable. Closes #957.
oskarwrobel referenced this issue in ckeditor/ckeditor5-engine May 17, 2017
@oskarwrobel
Merge pull request #958 from ckeditor/t/957
e3bc4d1 
Fix: None of the editable's ancestors should scroll when the DomConverter focuses an editable. Closes #957.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added module:view type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 11
2 participants
@oleq @mlewand