Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create diffrent opening and closing element in marker conversion #4003

Closed
oskarwrobel opened this issue Feb 27, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-engine#845
Closed

Create diffrent opening and closing element in marker conversion #4003

oskarwrobel opened this issue Feb 27, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-engine#845
Assignees
@oskarwrobel
Labels
package:engine type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 9

Comments

@oskarwrobel
Copy link
Contributor

Follow-up: https://github.com/ckeditor/ckeditor5-engine/issues/787

See: ckeditor/ckeditor5-engine#845 (comment)
@oskarwrobel oskarwrobel self-assigned this Feb 27, 2017
@oskarwrobel oskarwrobel changed the title Create diffrent opining and closing element in marker conversion Create diffrent opening and closing element in marker conversion Mar 3, 2017
oskarwrobel referenced this issue in ckeditor/ckeditor5-engine Mar 7, 2017
@oskarwrobel
Merge pull request #845 from ckeditor/t/787
2e7f75d 
Feature: Introduced markers serialization. Closes #787. Closes #846.

BREAKING CHANGES: `BuildModelConverter#fromMarkerCollapsed` is removed. Use `BuildModelConverter#fromMarker` instead.

NOTE: `insertUIElement` model to view converter now supports collapsed and non-collapsed ranges.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 9 milestone Oct 9, 2019
@mlewand mlewand added module:conversion type:task This issue reports a chore (non-production change) and other types of "todos". package:engine labels Oct 9, 2019
@oskarwrobel oskarwrobel mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oskarwrobel oskarwrobel

Labels
package:engine type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 9
Development

Successfully merging a pull request may close this issue.

Introduced markers serialization ckeditor/ckeditor5-engine
2 participants
@oskarwrobel @mlewand