Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OT: SplitDelta x RemoveDelta transformation throws for some split deltas #4138

Closed
scofalik opened this issue Aug 10, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1066
Closed

OT: SplitDelta x RemoveDelta transformation throws for some split deltas #4138

scofalik opened this issue Aug 10, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1066
Assignees
@scofalik
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 11

Comments

@scofalik
Copy link
Contributor

Original issue reported here: https://github.com/ckeditor/ckeditor5-undo/issues/65#issuecomment-321190168

The cause of the issue is that in certain cases, the first operation in SplitDelta may become a NoOperation. Special case transformation for SplitDelta x RemoveDelta is based on the first operation and when it becomes NoOperation or MoveOperation, it throws.
@scofalik scofalik self-assigned this Aug 10, 2017
pjasiun referenced this issue in ckeditor/ckeditor5-engine Aug 14, 2017
Merge pull request #1066 from ckeditor/t/1065
85e38e1 
Fix: Prevented editor throwing during SplitDelta x RemoveDelta transformation when SplitDelta's first operation was neither InsertOperation nor ReinsertOperation. Closes #1065.
Fix: Fixed remove model-to-view converter for some edge cases. Closes #1068.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added module:model type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Oct 9, 2019
@scofalik scofalik mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scofalik scofalik

Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 11
Development

Successfully merging a pull request may close this issue.

Fixed: Prevent throwing during SplitDelta x RemoveDelta transformation. ckeditor/ckeditor5-engine
2 participants
@scofalik @mlewand