Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should the image styles be configured to allow [ left, full, right ]? #2184

Closed
Reinmar opened this issue Apr 13, 2018 · 3 comments · Fixed by ckeditor/ckeditor5-build-decoupled-document#11
Closed

Should the image styles be configured to allow [ left, full, right ]? #2184

Reinmar opened this issue Apr 13, 2018 · 3 comments · Fixed by ckeditor/ckeditor5-build-decoupled-document#11
Assignees
@pomek
Labels
package:build-decoupled-document type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 16

Comments

@Reinmar
Copy link
Member

Reinmar commented Apr 13, 2018

By default, the image style feature enables [ full, side ] styles. This approach is not necessarily the best for the "document editor" where more visual features appear. So, perhaps, this build should be configured to [ left, full, right ] instead?

WDYT❓
@fredck
Copy link
Contributor

fredck commented Apr 13, 2018

It makes sense for me.

@wwalc
Copy link
Member

wwalc commented Apr 13, 2018 •
edited

What with centering the image?

@Reinmar
Copy link
Member Author

Reinmar commented Apr 13, 2018 •
edited

Dunno... no opinion. Would make it complete. But would also make the image toolbar look bad (conflict with full-size) :D

Reinmar referenced this issue in ckeditor/ckeditor5-build-decoupled-document Apr 18, 2018
@Reinmar
Merge pull request #11 from ckeditor/t/10
75855d9 
Other: Image styles should be configured to left-aligned, right-aligned image and full-size image (instead of the typical side-image and full-size image). Closes #10.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-build-decoupled-document Oct 8, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:build-decoupled-document labels Oct 8, 2019
@mlewand mlewand added this to the iteration 16 milestone Oct 8, 2019
@pomek pomek mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pomek pomek

Labels
package:build-decoupled-document type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 16
Development

Successfully merging a pull request may close this issue.

Image can be configured to left, right or full ckeditor/ckeditor5-build-decoupled-document
5 participants
@Reinmar @wwalc @fredck @pomek @mlewand