-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pinned Watchdog version leads to problems when updating #376
Labels
Milestone
Comments
We also planned to expose Watchdog on the Editor class to completely avoid this additional dependency. Some internal notes where we discussed this:
|
Scope
|
CKEditorBot
added
the
status:planned
Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon.
label
Jul 3, 2023
CKEditorBot
added
status:in-progress
Set automatically when an issue lands in the "In progress" column. We are working on it.
and removed
status:planned
Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon.
labels
Jul 7, 2023
This was referenced Jul 10, 2023
pomek
added a commit
that referenced
this issue
Jul 10, 2023
Other: The following packages are now marked as peer dependencies [`@ckeditor/ckeditor5-core`](https://www.npmjs.com/package/@ckeditor/ckeditor5-core), [`@ckeditor/ckeditor5-engine`](https://www.npmjs.com/package/@ckeditor/ckeditor5-engine), [`@ckeditor/ckeditor5-utils`](https://www.npmjs.com/package/@ckeditor/ckeditor5-utils) and [`@ckeditor/ckeditor5-watchdog`](https://www.npmjs.com/package/@ckeditor/ckeditor5-watchdog) to avoid issues when upgrading the CKEditor 5 version within the angular application. Closes #376. MAJOR BREAKING CHANGE: The[ `@ckeditor/ckeditor5-angular`](https://www.npmjs.com/package/@ckeditor/ckeditor5-angular) package requires the following peer dependencies: * [`@ckeditor/ckeditor5-core`](https://www.npmjs.com/package/@ckeditor/ckeditor5-core), * [`@ckeditor/ckeditor5-engine`](https://www.npmjs.com/package/@ckeditor/ckeditor5-engine), * [`@ckeditor/ckeditor5-utils`](https://www.npmjs.com/package/@ckeditor/ckeditor5-utils), * [`@ckeditor/ckeditor5-watchdog`](https://www.npmjs.com/package/@ckeditor/ckeditor5-watchdog). Make sure to install them in the same version as the editor build you want to use in your integration.
CKEditorBot
removed
the
status:in-progress
Set automatically when an issue lands in the "In progress" column. We are working on it.
label
Jul 10, 2023
pomek
added a commit
to ckeditor/ckeditor5
that referenced
this issue
Jul 10, 2023
Docs: Added documentation in Angular guide that `ckeditor5-angular` package requires peer dependencies. See ckeditor/ckeditor5-angular#376.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the published package on the npm, we pin a specific version of Watchdog which leads to problems when someone is using a different version of the editor or wants to update.
package.json
on npm:React on the other hand specifies Watchdog as a peer dependency:
.
Not sure what's the best approach to solve this but it's a major issue for some integrators.
The text was updated successfully, but these errors were encountered: