Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Token: Page break / hr to hook into Obsidian's thematicBreak #11

Open
5 tasks
chuangcaleb opened this issue Oct 6, 2023 · 0 comments
Open
5 tasks

Token: Page break / hr to hook into Obsidian's thematicBreak #11

chuangcaleb opened this issue Oct 6, 2023 · 0 comments
Labels
📋 a/task Type: Task Effort 🤚 b/help-needed Blocker: This ticket is too tough for me! Send help! ✨ o/feature (Feature Requests go to Discussions/Ideas!) Objective: New feature implementation 🪞 s/cm Scope: Codemirror

Comments

@chuangcaleb
Copy link
Owner

chuangcaleb commented Oct 6, 2023 •
edited
Loading

Describe the task

Turn Fountain page breaks into hr's.

However, Obsidian's Codemirror extension does some funny things to replace the hr with a Decoration.widget completely. Let's try to hook into their existing logic, rather than coding a brand new one from scratch.

  • Investigate if it is possible to hook into Obsidian's logic

Blocking

Expected behaviour

  • Source
  • Live preview
  • non-active line: will behaves just like native Obsidian hr
  • active line: goes back to "source" text

Screenshots

Additional context
@chuangcaleb chuangcaleb added ✨ o/feature (Feature Requests go to Discussions/Ideas!) Objective: New feature implementation 📋 a/task Type: Task Effort labels Oct 6, 2023
@chuangcaleb chuangcaleb changed the title Fountain syntax styling for page break / hr Fountain syntax for page break / hr Oct 6, 2023
@chuangcaleb chuangcaleb added the 🪞 s/cm Scope: Codemirror label Oct 6, 2023
@chuangcaleb chuangcaleb added the 🤚 b/help-needed Blocker: This ticket is too tough for me! Send help! label Oct 16, 2023
@chuangcaleb chuangcaleb changed the title Fountain syntax for page break / hr Token: Page break / hr to hook into Obsidian's thematicBreak Oct 16, 2023
@chuangcaleb chuangcaleb mentioned this issue Jan 29, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
📋 a/task Type: Task Effort 🤚 b/help-needed Blocker: This ticket is too tough for me! Send help! ✨ o/feature (Feature Requests go to Discussions/Ideas!) Objective: New feature implementation 🪞 s/cm Scope: Codemirror
Projects
obsidian-fountain-live
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chuangcaleb