{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":614611795,"defaultBranch":"main","name":"adhd","ownerLogin":"chromeos","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2023-03-16T00:20:03.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/55198424?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1721671918.0","currentOid":""},"activityList":{"items":[{"before":"debe6835a54b16b6b3aa587ad9c1cda94d993e2e","after":"0c3b002e6785bfa68c0468ce06aaaded8df87985","ref":"refs/heads/main","pushedAt":"2024-09-09T19:58:48.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"CRAS: move CRAS_NC_PROVIDER into types_internal.rs\n\nMoving so that CRAS_NC_PROVIDER can be accessed from S2.\ncras_nc.h is removed.\nTemporarily handle resolving nc provider in cras_iodev_list,\nwhich will be replaced by S2 later.\n\nBUG=b:353627012\nTEST=bazel test //... --config=local-clang --//:apm\n\nChange-Id: I92e3c7436ab03fecb33b564cab7cd29cbb0919d3\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5836313\nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nReviewed-by: Cranel W \nCommit-Queue: Hung-Hsien Chen \nReviewed-by: Li-Yu Yu ","shortMessageHtmlLink":"CRAS: move CRAS_NC_PROVIDER into types_internal.rs"}},{"before":"683d150582387ef363d653432b4d2f432cf02e47","after":"debe6835a54b16b6b3aa587ad9c1cda94d993e2e","ref":"refs/heads/main","pushedAt":"2024-09-09T15:39:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"CRAS: Not enable stream apms on floop streams\n\nFloop streams don't need any audio effect. Remove it to avoid\nresetting dsp when output devices change, which lead to reconnect\nstreams and cause underruns.\n\nBUG=b:364514332\nTEST=Run audio.FloopDeviceSwitch and check number of underruns.\n\nChange-Id: I55d284ced16d4ec02830e6a73e7d92cb96f1140c\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5836550\nReviewed-by: Li-Yu Yu \nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nCommit-Queue: ChromeOS Auto Retry \nAuto-Submit: Yu-Hsuan Hsu \nTested-by: Yu-Hsuan Hsu ","shortMessageHtmlLink":"CRAS: Not enable stream apms on floop streams"}},{"before":"33118ef743a6ac0e40fa319d05de544278976a7c","after":"683d150582387ef363d653432b4d2f432cf02e47","ref":"refs/heads/main","pushedAt":"2024-09-05T22:12:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"owners: remove Paul\n\nyou will be missed\n\nBUG=None\nTEST=None\n\nChange-Id: Ib0a03534499c13f65a764eec9cb8ee41c038163e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5840487\nAuto-Submit: Curtis Malainey \nReviewed-by: Li-Yu Yu \nTested-by: Curtis Malainey \nCommit-Queue: Li-Yu Yu \nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com ","shortMessageHtmlLink":"owners: remove Paul"}},{"before":"551f056147e78ee02661eb95f5ac512a7cdda73d","after":"33118ef743a6ac0e40fa319d05de544278976a7c","ref":"refs/heads/main","pushedAt":"2024-09-05T13:54:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"CRAS: clean up for moving nc_standalone_mode to S2\n\nRemove cras_system_get_noise_cancellation_standalone_mode().\nAll usage of this function is removed in https://crrev.com/c/5823496 .\n\nBUG=b:353627012\nTEST=bazel test //... --config=local-clang --//:apm\n\nChange-Id: I5b92db1eb6670e10ca4a2499368a578b6016c620\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5836312\nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nCommit-Queue: Hung-Hsien Chen \nReviewed-by: Li-Yu Yu ","shortMessageHtmlLink":"CRAS: clean up for moving nc_standalone_mode to S2"}},{"before":"b96e1235b76b737efb33276baefb5ee71929e94d","after":"551f056147e78ee02661eb95f5ac512a7cdda73d","ref":"refs/heads/main","pushedAt":"2024-09-05T11:03:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"Use cros format for Rust code\n\nBUG=None\nTEST=cros format `git ls-files '*.rs'`\n\nChange-Id: I2fc919fe377859096274ca4a7611d398d2fe343c\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5839086\nCommit-Queue: Hung-Hsien Chen \nCommit-Queue: Li-Yu Yu \nTested-by: Li-Yu Yu \nReviewed-by: Hung-Hsien Chen \nAuto-Submit: Li-Yu Yu ","shortMessageHtmlLink":"Use cros format for Rust code"}},{"before":"925eaf211cf54d77c82b27b51a662b64f5d67af8","after":"b96e1235b76b737efb33276baefb5ee71929e94d","ref":"refs/heads/main","pushedAt":"2024-09-05T08:18:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"sound_card_init: update VPD for rma_calibration\n\nPreviously it stored new calibration result in\n/var/lib/sound_card_init/. However, according to go/cros-fs-layout,\n/var/lib/ will be cleared after powerwash.\n\nShimless RMA process will disable write protection, so it would be\nmore robust to store calibration to VPD as well.\n\nThe result will be both stored in VPD and /var/lib/sound_card_init/\nas the boot time calibration saves to /var/lib/sound_card_init/ and\n/var/lib/sound_card_init/ has high priorty than VPD results.\n\nBUG=b:359708232\nTEST=`sound_card_init rma_calibration --id sofnau8825 --conf \\\n volmar.MAX98373.yaml --amp MAX98373`\n\n TEST=`/usr/bin/sound_card_init rma_calibration --id sofrt5682\n --amp\\\n MAX98390 --conf redrix.MAX98390.yaml`\n\nChange-Id: Ib74ec753e932470ae9d5ffdf53ef21cc59216789\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5833425\nReviewed-by: Baili Deng \nCommit-Queue: Judy Hsiao \nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com ","shortMessageHtmlLink":"sound_card_init: update VPD for rma_calibration"}},{"before":"09573910b688fa7be92c563533adbc69d5fc7abf","after":"925eaf211cf54d77c82b27b51a662b64f5d67af8","ref":"refs/heads/main","pushedAt":"2024-09-05T07:28:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"cras_tests: Print underrun duration\n\nBUG=b:364474071\nTEST=cras_tests control dump_audio_debug_info\n\nChange-Id: Ifc49705886d8df554539e97b0c5c0a85f8b521f5\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5829327\nAuto-Submit: Yu-Hsuan Hsu \nReviewed-by: Li-Yu Yu \nReviewed-by: Yu-Hsuan Hsu \nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nTested-by: Yu-Hsuan Hsu \nCommit-Queue: Yu-Hsuan Hsu ","shortMessageHtmlLink":"cras_tests: Print underrun duration"}},{"before":"6e15583898db2c43ed40efd3863cb5feda663680","after":"09573910b688fa7be92c563533adbc69d5fc7abf","ref":"refs/heads/main","pushedAt":"2024-09-05T05:49:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"ucm_converter: update config path and add enum_mixer_numeric_fallback attr\n\nBUG=b:348124498\nTEST=`python3 convert_all_ucm.py \\\n ${SRC}/overlays/overlay-brya/chromeos-base/chromeos-bsp-brya/files \\\n ../configs/ mixer`\n\nTEST=`python3 convert_all_ucm.py \\\n ${SRC}/overlays/overlay-brya/chromeos-base/chromeos-bsp-brya/files \\\n ../configs/ xml`\n\nChange-Id: I314c2b3b52c855819c9025f06f1793d62ddb71f9\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5836311\nTested-by: Judy Hsiao \nCommit-Queue: Judy Hsiao \nCommit-Queue: Li-Yu Yu \nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nReviewed-by: Li-Yu Yu \nCommit-Queue: ChromeOS Auto Runner \nAuto-Submit: Judy Hsiao ","shortMessageHtmlLink":"ucm_converter: update config path and add enum_mixer_numeric_fallback…"}},{"before":"ca16bc2a61ed0a751f334dcde54f861e259ab202","after":"6e15583898db2c43ed40efd3863cb5feda663680","ref":"refs/heads/main","pushedAt":"2024-09-03T13:49:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"floop: make no stream playback no-op\n\nWhen playback is not active, flexible loopback should return frames\nfilled with zeros. But this is handled in input side since there would\nbe cases that the playback side didn't started at all.\n\nSetting it to limit the source of filling zeros and avoid overfilling\nthe buffer.\n\nBUG=b:362679648\nTEST=tast run audio.FloopLifecycle.*\n\nChange-Id: Ib8a0e158d994064de8a91f14c8c3149f3bc0e632\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5828312\nTested-by: Terry Cheong \nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nReviewed-by: Yu-Hsuan Hsu \nCommit-Queue: Terry Cheong ","shortMessageHtmlLink":"floop: make no stream playback no-op"}},{"before":"a28560d18a5854b4666aa0cc8606f5feea63c5b4","after":"ca16bc2a61ed0a751f334dcde54f861e259ab202","ref":"refs/heads/main","pushedAt":"2024-09-02T16:39:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"floop: avoid overfilling the buffer\n\nAccount for the frames queued in buffer when filling zeros.\n\nBUG=None\nTEST=tast run audio.FloopLifecycle.*\n\nChange-Id: If069f64a1af5c2dc7f20d6d0b70981444fcdaf32\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/4721135\nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nCommit-Queue: Terry Cheong \nReviewed-by: Li-Yu Yu ","shortMessageHtmlLink":"floop: avoid overfilling the buffer"}},{"before":"0fe3ecc133a7694cf3527737921b985152adde6e","after":"a28560d18a5854b4666aa0cc8606f5feea63c5b4","ref":"refs/heads/main","pushedAt":"2024-09-02T03:35:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"CRAS: Attach streams at the same time\n\nAttach streams at the same time instead of adding them seperately. It\ncan avoid the first stream from committing data to a device before the\nsecond stream is added.\n\nBUG=b:361243861\nTEST=Switch devices when using Recorder App and Youtube at the same\ntime.\n\nChange-Id: I8e25045768e853680998efd0e92c1836a87316c6\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5828304\nReviewed-by: Li-Yu Yu \nReviewed-by: Terry Cheong \nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nCommit-Queue: Yu-Hsuan Hsu \nTested-by: Yu-Hsuan Hsu ","shortMessageHtmlLink":"CRAS: Attach streams at the same time"}},{"before":"90235d26e603d428dcaeee3d60ad0656bed4406c","after":"0fe3ecc133a7694cf3527737921b985152adde6e","ref":"refs/heads/main","pushedAt":"2024-08-30T10:09:38.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"CRAS: move DSP input effect blocking into S2.\n\nThe DSP input effect blocking flags were implemented in cras_iodev_list.\nMoving them into S2.\n\nThe audio effect decision process will need DSP blocking information in\nS2. It affects what to show in UI setting and which effect to apply on\nthe stream.\n\nDetailed design: go/cras-audio-effects-control .\n\nBUG=b:353627012\nTEST=bazel test //... --config=local-clang --//:apm\n\nChange-Id: Ifd429b91a14adb50c95376978d9e89fa3aec7834\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5823496\nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nReviewed-by: Li-Yu Yu \nCommit-Queue: Hung-Hsien Chen ","shortMessageHtmlLink":"CRAS: move DSP input effect blocking into S2."}},{"before":"75c4f25aa0604bd981b2cb3fccabdd85bedcab05","after":"90235d26e603d428dcaeee3d60ad0656bed4406c","ref":"refs/heads/main","pushedAt":"2024-08-28T11:30:56.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"s2: Determine beamforming DLC requirement based on config\n\nDuring development beamforming DLCs are swapped out with\nprocessing plugins with a hard coded path. In that case\nwe don't need to wait for the DLC to be available.\n\nFigure out the required DLCs by parsing the config file.\n\nFIXED=b:356757845\nTEST=audio_diagnostics with modified /etc/cras/processor/beamforming.txtpb\n\nChange-Id: I5738f6a33a0b7a020545c0b3f7c55c91bf6211d5\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5802748\nReviewed-by: Cranel W \nCommit-Queue: Li-Yu Yu \nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com ","shortMessageHtmlLink":"s2: Determine beamforming DLC requirement based on config"}},{"before":"27b99b4902535c6cc8e05f00f0f79252599f0940","after":"75c4f25aa0604bd981b2cb3fccabdd85bedcab05","ref":"refs/heads/main","pushedAt":"2024-08-27T17:23:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"CRAS: Print sleep_interval_ts\n\nsleep_interval_ts may be changed by the rate estimater.\n\nBUG=None\nTEST=check audio thread log\n\nChange-Id: I9e8e1d5d0446df853d37d0f4c1484d4eadfe0316\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5816148\nTested-by: Yu-Hsuan Hsu \nReviewed-by: Li-Yu Yu \nAuto-Submit: Yu-Hsuan Hsu \nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nCommit-Queue: Yu-Hsuan Hsu ","shortMessageHtmlLink":"CRAS: Print sleep_interval_ts"}},{"before":"8ba89ce0176e30541763d88fc432ab93615e47bb","after":"27b99b4902535c6cc8e05f00f0f79252599f0940","ref":"refs/heads/main","pushedAt":"2024-08-27T11:37:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"cras: dsp: Removed unused C files\n\nRemove the C files that have been completely ported into rust codes.\nThese C files have a copy in cras/src/dsp/c and are currently only used\nfor unit tests.\n\nBUG=b:352433455\nTEST=bazel test //...\n\nChange-Id: I05d6a1d4bc41f6a48cd429db7f44298f4a93d97d\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5815951\nReviewed-by: Li-Yu Yu \nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nAuto-Submit: Nathan Lee \nCommit-Queue: Nathan Lee ","shortMessageHtmlLink":"cras: dsp: Removed unused C files"}},{"before":"8e669c531ed3282bbc97da5bf026abba97074771","after":"8ba89ce0176e30541763d88fc432ab93615e47bb","ref":"refs/heads/main","pushedAt":"2024-08-27T08:20:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"sound_card_init: Update data format for TAS2563\n\ncrrev/c/5740263 updated the amixer format for Speaker Calibrated Data.\nUpdate sound_card_init to fit the new format.\n\nBUG=b:345629513\nTEST=`amixer -c 0 contents` and check that the Speaker Calibrated Data\nis applied correctly\n\nChange-Id: I54e1cfc263397042dcbca947dc2d987d51d1c40e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5803360\nReviewed-by: Yu-Hsuan Hsu \nCommit-Queue: Baili Deng \nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com ","shortMessageHtmlLink":"sound_card_init: Update data format for TAS2563"}},{"before":"cb8c8dd20a4f14320a9115d99981458c13451053","after":"8e669c531ed3282bbc97da5bf026abba97074771","ref":"refs/heads/main","pushedAt":"2024-08-26T06:29:04.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"CRAS: export effect only when dlc ready\n\nIf the effect bit isn't set, the frontend toggle should be hidden.\n\nChanges:\ns2\n* make ap_nc_allowed also depend on dlc state.\n* make style_transfer_allowed also depend on dlc state.\n* add beamforming_allowed that depends on dlc state.\ncras_iodev_list\n* seperate beamforming and 1p nc cases when exporting nc effect bit.\n\nBUG=b:359803173\nTEST=bazel test //...\n\nChange-Id: Iea8310e2bc3f0b10e500be9c58f2f37887f1af6a\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5804385\nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nAuto-Submit: Cranel W \nCommit-Queue: Li-Yu Yu \nReviewed-by: Li-Yu Yu ","shortMessageHtmlLink":"CRAS: export effect only when dlc ready"}},{"before":"a730f8428cb8b92863add26ea14e1b83f725a077","after":"cb8c8dd20a4f14320a9115d99981458c13451053","ref":"refs/heads/main","pushedAt":"2024-08-26T03:20:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"build_kzip.bash: Update corpus name\n\nBUG=b:361828891, b:361781876\nTEST=None\n\nChange-Id: I7f0a115b47ddc1d9ba729196930a32cee4eb3bf1\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5802933\nReviewed-by: Yu-Hsuan Hsu \nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nCommit-Queue: ChromeOS Auto Runner \nCommit-Queue: Li-Yu Yu \nReviewed-by: Josip Sokcevic ","shortMessageHtmlLink":"build_kzip.bash: Update corpus name"}},{"before":"4d12fbf5ba5260b158f5db3dbb37cc28ddd7d8ce","after":"a730f8428cb8b92863add26ea14e1b83f725a077","ref":"refs/heads/main","pushedAt":"2024-08-23T09:06:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"floss: add |is_sco_connected| logic\n\n|is_sco_stopped| was introduced in CL:5446837 to distinguish if a\nprevious SCO disconnection was initiated by the host, which is a factor\nof making the decision to reconnect the device.\n\nHowever, when a disconnection is initiated by the host, and another\nconnection request is initiated by the host, and the disconnection\nevent arrives after then, CRAS has to determine that this was actually\ncaused by the previous disconnection request from the host and ignore it.\n\nHere we introduce the strong assumption that, for every connected SCO,\nthere must be a disconnection event that entails. With this, we will\nmaintain a variable that allows CRAS to reject SCO open requests in the\nevent that the previous has not disconnected (i.e., fully respecting\nthe fact that |is_sco_stopped| doesn't necessarily imply\n|!is_sco_connected| and vice versa).\n\nBUG=b:352497401\nTEST=Verify SCO works well with stress test\n\nChange-Id: Ide640b8c19fbc3b802c4d1dfe0f25e919257de61\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5796322\nCommit-Queue: Jeremy Wu \nReviewed-by: Hsinyu Chao \nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com ","shortMessageHtmlLink":"floss: add |is_sco_connected| logic"}},{"before":"c3591ecc5d1fffc7442f144c0032644a162c449c","after":"4d12fbf5ba5260b158f5db3dbb37cc28ddd7d8ce","ref":"refs/heads/main","pushedAt":"2024-08-23T06:52:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"sound_card_init: Set 2 minute timeout for wait_for_speakers_ready\n\nThe slow CRAS detection can still be triggered.From current testing, the\nmax delay seen from sound_card_init triggering to CRAS actually\ndetecting the speaker is roughly 1 minute.\n\nIncrease the retry count so that the timeout is 2 minutes to prevent the\nissue.\n\nBUG=b:357556530\nTEST=cros build-packages --board=geralt media-sound/sound_card_init\n\nChange-Id: Id4151a39a99122e9fbb7419831433faf37a91215\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5802550\nAuto-Submit: Baili Deng \nCommit-Queue: Baili Deng \nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nReviewed-by: Judy Hsiao ","shortMessageHtmlLink":"sound_card_init: Set 2 minute timeout for wait_for_speakers_ready"}},{"before":"bcb92a1501c85b6081150781f599058d88e328f4","after":"c3591ecc5d1fffc7442f144c0032644a162c449c","ref":"refs/heads/main","pushedAt":"2024-08-22T15:12:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"sound_card_init: add rma_calibration for max98390 and max98373\n\nAdd `rma_calibration` subcommand for max98390 and max98373.\nThe command will be executed in the RMA flow to replace the boot\ntime calibration. For OEMs may fail to run the RMA flow and require\nre-calibration at every boot, they can still set boot time calibration\nto true in the sound_card_init config. Otherwise, it will default to\nfalse.\n\nMore context: The drawback of boot time calibration is that we use\nheuristics to determine whether the speakers are replaced and whether\nthey are properly cooled down at every boot time. The calibration value\nmight be updated even when there is no speaker replacement.\n\nBUG=b:359708232\nTEST=`sound_card_init rma_calibration --id sofnau8825 --conf \\\n volmar.MAX98373.yaml --amp MAX98373`\n\nTEST=`/usr/bin/sound_card_init rma_calibration --id sofrt5682 --amp\\\n MAX98390 --conf redrix.MAX98390.yaml`\n\nChange-Id: I76773eae36574e53b6e04d6e0bee2139a704d641\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5796287\nReviewed-by: Baili Deng \nCommit-Queue: Judy Hsiao \nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com ","shortMessageHtmlLink":"sound_card_init: add rma_calibration for max98390 and max98373"}},{"before":"e2d7dfd5752f43cbb50893f2e8e2af2216ba9b8e","after":"bcb92a1501c85b6081150781f599058d88e328f4","ref":"refs/heads/main","pushedAt":"2024-08-22T09:42:13.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"cras: dsp: Allow dsp_golden_unittest to generate golden output\n\nAdd a cc_binary bazel target to allow dsp_golden_unittest to export the\noutputs when executed with 'bazel run'.\n\nBUG=b:352433455\nTEST=bazel test //...\n\nChange-Id: I0cef65d8c8e06d0cc64d15b2a66af3c985c59860\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5796590\nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nReviewed-by: Li-Yu Yu \nCommit-Queue: Nathan Lee ","shortMessageHtmlLink":"cras: dsp: Allow dsp_golden_unittest to generate golden output"}},{"before":"bc1848d25c0d530ee8e08655b624ba92eac6a3e6","after":"e2d7dfd5752f43cbb50893f2e8e2af2216ba9b8e","ref":"refs/heads/main","pushedAt":"2024-08-22T02:04:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"a2dp: block bogus codec types\n\nFuzzer found a way to do a negative shift. Whoops.\n\nBUG=oss-fuzz:67576\nTEST=build\n\nChange-Id: Ie107c6ab00354dba779a8dee9cdafe319a1e6785\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5797753\nTested-by: Curtis Malainey \nAuto-Submit: Curtis Malainey \nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nCommit-Queue: Curtis Malainey \nReviewed-by: En-Shuo Hsu ","shortMessageHtmlLink":"a2dp: block bogus codec types"}},{"before":"1db615dd9ceb4e5524eaee8a37ecc1f8575be235","after":"116bbfbbd1c243028d480b24b454b34815391ede","ref":"refs/heads/dependabot/cargo/openssl-0.10.66","pushedAt":"2024-08-20T14:15:43.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"},"commit":{"message":"build(deps): bump openssl from 0.10.62 to 0.10.66\n\nBumps [openssl](https://github.com/sfackler/rust-openssl) from 0.10.62 to 0.10.66.\n- [Release notes](https://github.com/sfackler/rust-openssl/releases)\n- [Commits](https://github.com/sfackler/rust-openssl/compare/openssl-v0.10.62...openssl-v0.10.66)\n\n---\nupdated-dependencies:\n- dependency-name: openssl\n dependency-type: direct:production\n...\n\nSigned-off-by: dependabot[bot] ","shortMessageHtmlLink":"build(deps): bump openssl from 0.10.62 to 0.10.66"}},{"before":"7c089dbcf991729ea4960695bc144672b6b71b51","after":"bc1848d25c0d530ee8e08655b624ba92eac6a3e6","ref":"refs/heads/main","pushedAt":"2024-08-20T14:14:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"Move CrasDlcId into types_internal.rs\n\nThis is mainly for s2 to access CrasDlcId and avoid cyclic dependency.\nBefore this change, dlc depends on s2, and CrasDlcId is defined in dlc.\nAfter this change, dlc depends on types_internal and s2, and s2 can\ndepend on types_internal.\n\nPer discussion, we decided not to make it a crate to keep the original\ndesign: 1 crate with 1 header.\n\nBUG=b:359803173\nTEST=bazel test //...\n\nChange-Id: I474fc294d5e6e0d6db4f7378c6b7ebd7d2ea41e5\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5790042\nTested-by: Cranel W \nCommit-Queue: Cranel W \nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nReviewed-by: Li-Yu Yu ","shortMessageHtmlLink":"Move CrasDlcId into types_internal.rs"}},{"before":"ffb959854762dc21048cc84c3e9622032a662605","after":"7c089dbcf991729ea4960695bc144672b6b71b51","ref":"refs/heads/main","pushedAt":"2024-08-20T08:04:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"CRAS: remove nuance-dlc\n\nBUG=b:359496197\nTEST=CQ\n\nDisallow-Recycled-Builds: test-failures\nCq-Depend: chromium:5790287\nChange-Id: Ic1926401f9193c1477b8fbf2df6604e0844623bb\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5792815\nReviewed-by: Li-Yu Yu \nCommit-Queue: Cranel W \nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com ","shortMessageHtmlLink":"CRAS: remove nuance-dlc"}},{"before":"3561346fe62488dc84dda12809b897a9810a3b80","after":"ffb959854762dc21048cc84c3e9622032a662605","ref":"refs/heads/main","pushedAt":"2024-08-19T21:17:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"audio: Allow sidetone for USB device\n\nBUG=b:328145742\nTEST=plug in a USB headphone, launch sidetone\n\nChange-Id: If39d4680f24120a8c05f624c53d08929eb1356ae\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5793343\nCommit-Queue: Norman Bintang \nTested-by: Norman Bintang \nReviewed-by: Judy Hsiao \nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com ","shortMessageHtmlLink":"audio: Allow sidetone for USB device"}},{"before":"7434bfa4617ccc19ab8fedb34864dd1636a5f733","after":"3561346fe62488dc84dda12809b897a9810a3b80","ref":"refs/heads/main","pushedAt":"2024-08-19T05:35:51.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"CRAS: Log NC provider with string instead of enum value.\n\nIn cras_iodev_list_reset_for_noise_cancellation(), log the restart_tag\nof the iodev with strings instead of enum value.\n\nBUG=b:353627012\nTEST=bazel test //... --config=local-clang --//:apm\n\nChange-Id: I2299c680daff28676f87bc7ff21d27632a693a64\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5785742\nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nReviewed-by: Li-Yu Yu \nCommit-Queue: Hung-Hsien Chen ","shortMessageHtmlLink":"CRAS: Log NC provider with string instead of enum value."}},{"before":"2825d1a8f68515a5b1bec907ab01d711a73a1fb0","after":"7434bfa4617ccc19ab8fedb34864dd1636a5f733","ref":"refs/heads/main","pushedAt":"2024-08-19T03:52:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"sound_card_init: Handle and reset invalid DataStore values\n\nCurrently, boot_time_calibration for Maxim smart amps will fail with\nerrors when encountering invalid DataStore values.\n\nTo fix the issue, adjust the paths so that they handle the errors\nproperly. Also, when encountering invalid DataStore values, reset it to\nuse VPD instead.\n\nBUG=b:357556530\nTEST=cros build-packages --board=geralt media-sound/sound_card_init\nTEST=Create garbage data for /var/lib/sound_card_init/sofmt8188m98390/calib_0\nTEST=Check that the boot_time_calibration uses VPD and resets previous\nvalue to VPD\n\nChange-Id: Ia5da736ca6c6cceb3766505302b8982dd370bece\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5785120\nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nCommit-Queue: Baili Deng \nReviewed-by: Judy Hsiao ","shortMessageHtmlLink":"sound_card_init: Handle and reset invalid DataStore values"}},{"before":"6e54f4bc4b02ac0d01d8824f745e52a764df552d","after":"2825d1a8f68515a5b1bec907ab01d711a73a1fb0","ref":"refs/heads/main","pushedAt":"2024-08-19T02:57:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"CRAS: use the new nc-ap-dlc\n\nThe new nc-ap-dlc contains both of noise cancellation and style\ntransfer.\n\nBUG=b:359496197\nTEST=CQ\n\nCq-Depend: chrome-internal:7584842\nChange-Id: I050cc9ab5f00e4586736f820fb93c2687ad1f67b\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5782677\nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nCommit-Queue: Cranel W \nReviewed-by: Li-Yu Yu ","shortMessageHtmlLink":"CRAS: use the new nc-ap-dlc"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEsU5BkwA","startCursor":null,"endCursor":null}},"title":"Activity · chromeos/adhd"}