Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible test failure in upcoming Julia version 1.5 #39

Open
rfourquet opened this issue May 3, 2020 · 2 comments
Open

possible test failure in upcoming Julia version 1.5 #39

rfourquet opened this issue May 3, 2020 · 2 comments

Comments

@rfourquet
Copy link

A PkgEval run for a Julia pull request which changes the generated numbers for rand(a:b) indicates that the tests of this package might fail in Julia 1.5 (and on Julia current master branch).

Also, you might be interested in using the new StableRNGs.jl registered package, which provides guaranteed stable streams of random numbers across Julia releases.

Apologies if this is a false positive. Cf. https://github.com/JuliaCI/NanosoldierReports/blob/ab6676206b210325500b4f4619fa711f2d7429d2/pkgeval/by_hash/52c2272_vs_47c55db/logs/LLLplus/1.5.0-DEV-87d2a04de3.log

@chrisvwx
Copy link
Owner

chrisvwx commented May 4, 2020

Thanks! I will look at this more next week; I may wait until we're closer to 1.5 to address it.

StableRNGs looks like it's your package; it looks interesting and useful. If I read the README right, you're using a linear congruential generator (LCG). As a bit of trivia, I think the LLL can be used to implement Knuth's Spectral test of LCGs; see section 3.3.4 of vol 2

@rfourquet
Copy link
Author

StableRNGs looks like it's your package

Yes I made it because some people dislike that the RNG can change in minor Julia version :)
Thank you for the pointer to Knuth's Spectral test, I will have a closer look when I have time. I would believe BigCrush includes such a test, but I will have to check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants