Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name ID 3 also needs to be changed (unique identifier) #9

Open
me-ans opened this issue Nov 20, 2023 · 3 comments
Open

Name ID 3 also needs to be changed (unique identifier) #9

me-ans opened this issue Nov 20, 2023 · 3 comments

Comments

@me-ans
Copy link

me-ans commented Nov 20, 2023

The unique identifier also needs to be changed. Adding this to the code fixes it (line 94):

 elif record.nameID == 3:
       record.string = nameID6_string

The issue made a font unusable by some applications.
Hope it helps!

@chrissimpkins
Copy link
Owner

Thanks! Do you have information on the applications where this is important?

@me-ans
Copy link
Author

me-ans commented Nov 21, 2023

An application has crashed here that uses the unique ID internally to distinguish fonts. Another issue may arise when the OS uses this information to check for conflicts, duplicates, etc.

Open Font Book on macOS and see how all other fonts consistently use the ID (as far as I could see, they are all using the PostScript ID for this). It's probably similar on Windows.

@me-ans
Copy link
Author

me-ans commented Nov 21, 2023

At any rate, it would be weird to keep the OLD name as the unique ID when all other names have changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants