-
Notifications
You must be signed in to change notification settings - Fork 36
Missing Permission for Spot Instance Creation #7
Comments
Hi @MartinLoeper ! Thanks a lot for your interest in this project and your report. I'm afraid I tested this on an account that already had a service linked role, so the I might try to force the creation of the service-linked role in the CloudFormation template to ensure it's present, but I wonder if that will work… 🤔 |
Hi @fquffio, unfortunately I do not know which service linked role has to be created there. 😆 I just wanted to make it work as quickly as possible and adding the permission above works well. |
I'll try to open a PR in the afternoon, but I'm afraid you'd have to delete all service-linked roles before testing… 😞 I might try to find an AWS account in which I have never used spot instances. 🤔 |
I ran into the same issue. Here the PR #12 |
Looks like AWS creates the AWSServiceRoleForEC2Spot role automatically on the first ever spot instance request. |
I use spot instances for runners.
However, after setting GitLabRunnerSpotInstance to "Yes", the manager could not create the new machines and the logs stated that:
I had to add "iam:CreateServiceLinkedRole" for resource "*" to the manager's inline policy "Runners".
I got the information from a related issue: LeanerCloud/AutoSpotting#187
The text was updated successfully, but these errors were encountered: