-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeScript types #11
Comments
@LeoTindall I don't use TypeScript (and not familiar with it), what are your issues? what do you need exactly? |
The problem is that the TypeScript type checker complains when I try to configure the library. I'm happy to submit a PR with the d.ts file, I was just wondering if you'd be willing to accept it. |
@LeoTindall are you planning on adding this to the Chart.js typings or a seperate file for the plugin? |
@LeoTindall sorry for the late reply: I'm not against the TypeScript definition in this repository (as long as it respects the ESLint code style), however since this plugin is not written using TypeScript, this file will likely not be maintained. Wouldn't be easier to simply update the Chart.js TypeScript and allow any type for |
Not a bad idea! I'll make a PR against their repo, thanks. |
@LeoTindall sounds good, can you please link that ticket to your PR when ready? |
@LeoTindall How do I integrate this into my existing typescript project? It throws errors saying it can't find the definition for various files. |
Currently, I have issues using this library with my typescript project; could you include a TypeScript types definition file?
Many thanks.
The text was updated successfully, but these errors were encountered: