Allow to configure the branch where the pull request is created

[pradel]

Hi, I would like to know if you are open to the idea of having the ability to change the branch that the release pull request is created via an option.

For the context, in my company we are using the git-flow process, all the code changes are merged into our develop branch, we create a release branch targeting master with all the changes and then once merged, merge master into our develop branch.
We would like to start using changeset into our flow but with this action the new release pr is always targeting our develop branch but we would like it to point to master.

I hope my use case is clear, if you think this change makes sense I can work on this :)

[Andarist]

Hm, the git-flow is quite popular so I'm inclined to say that maybe we should provide better means to deal with this in the core.

It should be possible to add a step that would just change the base of created PR. Which we could make even easier if we'd output the PR number. The downside of this approach though is that it would mess up this search:

action/src/run.ts

Line 206 in c291823

let searchQuery = `repo:${repo}+state:open+head:${versionBranch}+base:${branch}`;

As to the more built-in support for this - any ideas regarding the API, config option names etc?

[pradel]

I think my first idea (which might be wrong) is to have just a baseBranch and targetBranch option where I could set develop to baseBranch and master to targetBranch.

[Andarist]

Hm, it could be still confusing to have those two in the config - although I agree that the chosen name has a nice ring to it. The problem is not really in that proposed flag, but more in the existing baseBranch - what people think about when they see a baseBranch?

That option would also only be relevant for the action here (at least for now) which kinda adds to the confusion. OTOH - the CLI (and its config) is a central place and people don't care that much how our architecture is fragmented right now in the CLI, Action, and Bot. So this could be thought of as a DX improvement.

@mitchellhamilton any particular thoughts about this?

[emmatown]

Having a target branch option (in the action config, not the changesets config) seems fine.

[nisimpson]

Hi all, any decisions made on this issue?

[ryanovas]

I would also like to know if there's any progress on this?