Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move createRelease logic to @changesets/cli? #49

Open
ianwalter opened this issue Aug 3, 2020 · 1 comment
Open

Move createRelease logic to @changesets/cli? #49

ianwalter opened this issue Aug 3, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@ianwalter
Copy link

It would be nice to be able to use the createRelease logic found here locally, perhaps as a separate release command in the CLI. So that you could do something like:

  1. yarn changesets version
  2. yarn changesets publish
  3. GITHUB_TOKEN=xxx yarn changesets release or yarn changesets release --token xxx

My use case is testing local changes to @changesets/cli but I think it would be good to not have to rely on the GitHub actions, say if GitHub Actions is down but the API is not, or some other reason preventing the action from executing. You could fallback to running the process locally. What do you think?

@Andarist
Copy link
Member

Andarist commented Aug 4, 2020

At the high-level it seems useful for me - it would allow integrating this part of the workflow into other CIs.

The current implementation of the createRelease is based partially on reading FS information - which makes it less flexible and more error-prone. I think it would be best to avoid such things and if we split this into a separate command we end up again with a state-sharing problem between both commands. OTOH it would be great to have this as a separate command as we'd like to keep things decoupled from each other, keeping responsibilities separated nicely.

Those are just some random thoughts from me right now, I don't know what's the best answer for this just yet.

@Andarist Andarist added the enhancement New feature or request label Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants