Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog is not updating in "Version Packages" PR #270

Closed
nwalters512 opened this issue Feb 28, 2023 · 2 comments
Closed

Changelog is not updating in "Version Packages" PR #270

nwalters512 opened this issue Feb 28, 2023 · 2 comments

Comments

@nwalters512
Copy link

See https://github.com/PrairieLearn/PrairieLearn/pull/7213/files: this Action correctly bumps the version in package.json and removes the files under .changeset/, but it did not update packages/opentelemetry/CHANGELOG.md. The same thing happened with the previous PR that releases version 1.6.0 of this package.

@nwalters512
Copy link
Author

Looks like this may have been caused by Prettier crashing:

setting git user
/usr/bin/git config user.name "github-actions[bot]"
/usr/bin/git config user.email "github-actions[bot]@users.noreply.github.com"
setting GitHub credentials
/usr/bin/git checkout changeset-release/master
error: pathspec 'changeset-release/master' did not match any file(s) known to git
/usr/bin/git checkout -b changeset-release/master
Switched to a new branch 'changeset-release/master'
/usr/bin/git reset --hard ee0c530b57265949db4919293fb4afd51af3e708
HEAD is now at ee0c530b5 Stop workspaces after being in background for a while (#7196)
/opt/hostedtoolcache/node/16.19.1/x64/bin/node /home/runner/work/PrairieLearn/PrairieLearn/node_modules/@changesets/cli/bin.js version
Error: Cannot find module '/home/runner/work/PrairieLearn/PrairieLearn/node_modules/@prairielearn/prettier-plugin-sql/dist/index.js'. Please verify that the package.json has a valid "main" entry
    at tryPackage (node:internal/modules/cjs/loader:425:19)
    at Function.Module._findPath (node:internal/modules/cjs/loader:638:18)
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:[10](https://github.com/PrairieLearn/PrairieLearn/actions/runs/4296442238/jobs/7488169038#step:5:11)07:27)
    at resolve (node:internal/modules/cjs/helpers:[11](https://github.com/PrairieLearn/PrairieLearn/actions/runs/4296442238/jobs/7488169038#step:5:12)4:19)
    at /home/runner/work/PrairieLearn/PrairieLearn/node_modules/prettier/index.js:38[12](https://github.com/PrairieLearn/PrairieLearn/actions/runs/4296442238/jobs/7488169038#step:5:13)1:24
    at Array.map (<anonymous>)
    at /home/runner/work/PrairieLearn/PrairieLearn/node_modules/prettier/index.js:38119:47
    at Array.flatMap (<anonymous>)
    at Object.load (/home/runner/work/PrairieLearn/PrairieLearn/node_modules/prettier/index.js:381[13](https://github.com/PrairieLearn/PrairieLearn/actions/runs/4296442238/jobs/7488169038#step:5:14):60)
    at Object.load [as loadPlugins] (/home/runner/work/PrairieLearn/PrairieLearn/node_modules/prettier/index.js:16[14](https://github.com/PrairieLearn/PrairieLearn/actions/runs/4296442238/jobs/7488169038#step:5:15)7:[23](https://github.com/PrairieLearn/PrairieLearn/actions/runs/4296442238/jobs/7488169038#step:5:24)) {
  code: 'MODULE_NOT_FOUND',
  path: '/home/runner/work/PrairieLearn/PrairieLearn/node_modules/@prairielearn/prettier-plugin-sql/package.json',
  requestPath: '@prairielearn/prettier-plugin-sql'
}
🦋  All files have been updated. Review them and commit at your leisure

@nwalters512
Copy link
Author

Can confirm that Prettier was the issue. Apologies for the noise!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant