-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publishing via action while using "ignore" option #241
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have a monorepo of packages and want to use the "ignore" option to skip versioning and publishing a package temporarily.
The initial run of the workflow correctly runs the version, which respects the ignore option and only consumes, bumps version, and updates changelog for packages not ignored.
However, the subsequent run of the workflow still detects the leftover changeset markdown files of the ignored package, i.e.
hasChangesets
is true and tries to run the version again. If the detected changesets are all for ignored packages,hasChangesets
should be set to false and enter the publish flow.From what I can tell, the "ignore" option is only read and considered in
@changesets/assemble-release-plan
.Instead of just reading all changesets below,
action/src/index.ts
Line 36 in 595655c
perhaps it would be better to use
@changesets/get-release-plan
to get releasable changesets?The text was updated successfully, but these errors were encountered: