-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Action updating closed PR instead of opening a new one #24
Comments
I can confirm this is happening, the logs even show that the PR is closed:
|
Could someone provide a reproduction? There's not much we can do without one |
We have a normal setup with lerna, no custom scripts of any kind.
Nothing crazy going on, just the normal flow. |
Here's an example of an action run that updates a closed release PR instead of opening a new one: https://github.com/sketch-hq/sketch-assistant-utils/runs/589060995?check_suite_focus=true Observe the
The problem appears to be somewhat sporadic also. Is the GitHub API just occasionally crapping out and not respecting the query filter? |
I think filtering out PRs where the state isn't open should solve this then? Happy to accept a PR for that |
I've recently started noticing on one of my repos that this action is updating the most recent old/closed versioning PR, instead of opening a new one. Presumably something wonky with the search query defined here?
I can manually create a new PR based on the branch that the action created, and that works fine to merge and release the packages.
The text was updated successfully, but these errors were encountered: