Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue] When publishing, an error from one package breaks the call to create a tag for all the others #218

Open
ruscon opened this issue Oct 2, 2022 · 4 comments

Comments

@ruscon
Copy link

ruscon commented Oct 2, 2022

for example
2 packages should be published:

  • package A
  • package B

If for some reason the package A fails to publish to npm, but the package B publishes successfully, then the git tag and github release for the package B will not be generated.

@Andarist
Copy link
Member

Andarist commented Oct 2, 2022

That is true - but it's also a little bit complicated to fix. Should package B even be considered to be successfully published in this case? What if it, let's say, depends on package A?

@ruscon
Copy link
Author

ruscon commented Oct 3, 2022

@Andarist It would be cool if the packages were published one by one, taking into account the dependencies among themselves, but in this case, this is not important. Consider that packages do not depend on each other in this case.

@Andarist
Copy link
Member

Andarist commented Oct 3, 2022

Well, this case is important for designing how it should work. I agree that this is overall a problem worth solving but to do that we need to consider all the possible situations.

@ruscon
Copy link
Author

ruscon commented Oct 4, 2022

@Andarist I think that everything should start with the fact that need a function to calculate the dependency tree. This exists, for example, in (nx affected. nx affected compute a list of changed packages based on the difference between two commits.
Would the same solution work here as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants