Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not list private packages in version PR #214

Open
unional opened this issue Sep 10, 2022 · 5 comments
Open

Should not list private packages in version PR #214

unional opened this issue Sep 10, 2022 · 5 comments

Comments

@unional
Copy link

unional commented Sep 10, 2022

And the private package workspace:* don't need to get updated.

e.g.:
clibuilder/clibuilder#407
image

@smeijer
Copy link

smeijer commented Apr 21, 2023

I think it should? I'm using changesets in a private workspace with exclusively private packages and apps, just for the sake of tracking changes in the pull request, and releases page.

Why are you using changeset for those private packages if you don't want it to show the changes or bump the version?

@unional
Copy link
Author

unional commented Apr 21, 2023

Private packages are private. They are not published nor tracked. e.g. project configs, test packages, examples, github docs.

Their changes are tracked by source control commits. There is no need to track for versions.
There is no audience for those versions.

@smeijer
Copy link

smeijer commented Apr 22, 2023

In my case, there definitely is. I'm tracking my apps and apis. The source is not published to anyone, but the changes are tracked for customers, and communicated via a changelog and newsletter.

I don't track them all, so I never commit a changeset for say a project config, or tests.

Are you perhaps looking for the ignore option?

@unional
Copy link
Author

unional commented Apr 22, 2023

The ignore option supposed to be a temp solution.
I can see your needs, so the question is how to handle both cases.

One way is to skip private packages without a version field.

Currently, there is another bug that requires private package to have a version field, or else the publish fails.

@unional
Copy link
Author

unional commented Apr 29, 2023

FYI, here is a problem with the ignore option: changesets/changesets#1093

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants