fix output flag published is always false when used with changeset publish --no-git-tag
#142
Conversation
🦋 Changeset detectedLatest commit: 377879b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -142,17 +138,16 @@ export async function runPublish({ | |||
| } | |||
| } | |||
|
|
|||
| const result: PublishResult = { published: true, publishedPackages: [] }; | |||
There was a problem hiding this comment.
I thought a lot about this. This somewhat changes the meaning of published, with this, it means: as long as the publishing script runs fine, we consider published=true, in a way, this is coherent with the definition of the flag in our README file: A boolean value to indicate whether a publishing is happened or not. Like I said in the issue created, I think the main issue here is we need a flag to tell us in the Github action script that whether publishing or versioning (creating the New Version PR) happened.
There was a problem hiding this comment.
I agree that relying on the New tag: output is less than ideal. However, you can (sort of) check today which script has been executed by inspecting the hasChangesets output:
https://github.com/changesets/action/pull/136/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R165
There was a problem hiding this comment.
hm, thinking about it, looks like my approach is quite wrong though. Will close this PR.
Fix #141