Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Changeset file with empty content will fail #138

Closed
akphi opened this issue Jan 21, 2022 · 1 comment · Fixed by changesets/changesets#740
Closed

Bug: Changeset file with empty content will fail #138

akphi opened this issue Jan 21, 2022 · 1 comment · Fixed by changesets/changesets#740

Comments

@akphi
Copy link
Contributor

akphi commented Jan 21, 2022

If I have these 2 changeset files

File 1

---
"a": patch
---

File 2

---
"a": patch
---

File 1 will fail the pipeline while file 2 will not - See this example

https://github.com/finos/legend-studio/runs/4899417130?check_suite_focus=true


I can help look at a fix for this issue, but please let me know if this is intended or if you would treat this as a bug and willing to let me work on it. Thanks!

@Andarist
Copy link
Member

I would classify this as a bug - the fix would involve adjusting this regex:
https://github.com/changesets/changesets/blob/c68536edf4c04e7fdf5594ec9c69471cd86fd0ce/packages/parse/src/index.ts#L4

If you could work on that - that would be splendid. Remember that a PR like this should come with a test covering the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants