Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the upload_url available as an action output #124

Open
filiptronicek opened this issue Dec 14, 2021 · 3 comments
Open

Make the upload_url available as an action output #124

filiptronicek opened this issue Dec 14, 2021 · 3 comments

Comments

@filiptronicek
Copy link

filiptronicek commented Dec 14, 2021

Hi there! 馃憢

It would be great to return the upload_url when a release is created (otherwise it could just be undefined), because it is often useful to be able to automatically upload artifacts. This is required with actions like https://github.com/actions/upload-release-asset.

@Andarist
Copy link
Member

Do we know what's the size limit for github action's output? I can't find any info about this.

Given how we often create multiple releases per run - do you have any specific format of the value for this output in mind?

@filiptronicek
Copy link
Author

Thanks for the quick response, @Andarist!

I think the upload_url could be provided in addition to other outputs queriable for the created release - there is an example of those values in the REST API docs. The upload_url shouldn't exceed any size constraints, I would imagine it similar to what the https://github.com/google-github-actions/release-please-action action does [their docs].

@Andarist
Copy link
Member

I'm not that worried about a single upload_url exceeding the limit. Our action can create multiple GitHub releases at once when working with monorepos. So I wonder what would happen if we, let's say, create a hundred releases. We'd have to put 100 URLs in the output - so I wonder if that's OK or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants