Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling custom commit message templates #10

Open
harrysolovay opened this issue Dec 19, 2019 · 2 comments
Open

Enabling custom commit message templates #10

harrysolovay opened this issue Dec 19, 2019 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@harrysolovay
Copy link

This action can't be used in conjunction with varying commit linting configurations, as there's no way to customize the template from which the commit message is generated. I'm trying to use commitlint with a conventional commits config. I see that the action is writing the following commit messages...

when commiting for the sake of PR generation: CHANGESET: thick-mayflies-learn...
when commiting version bumps: Version Packages

This causes any commit-linting CI to fail with something along the following lines:

Screen Shot 2019-12-19 at 8 31 18 AM

Side node: the placeholders (thick-mayflies-learn...) are awesome. Very tasteful.

@Noviny
Copy link
Contributor

Noviny commented Dec 19, 2019

Is this using the action to create the PRs? I just realised what repo this was...

For most use-cases, I recommend having the commit flag in config set to false, but if our CLI is breaking this, I agree this needs to be configurable.

(one of our goals is to have no ownership of how you git, so you can git however you think is best)

I'm probably not going to have immediate time to jump on this btw, but will add some labels.

@Noviny Noviny added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Dec 19, 2019
@jorenbroekema
Copy link

This can be closed I think, it works now:

Example:

- name: Create Release Pull Request or Publish to npm
  id: changesets
  uses: changesets/action@master
  with:
    # This expects you to have a script called release which does a build for your packages and calls changeset publish
    publish: npm run release
    commit: "chore: release"
  env:
    GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
    NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants
@harrysolovay @Noviny @jorenbroekema and others