fix: avoid reset scroll position on opening popover #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3ef26ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 71 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tsukkee
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1542
📝 Description
As described on #1542, the popover component will reset scroll position when it is opened.
I found
{ preventScroll: true }parameter ofHTMLElement.focus()is missing after 0.50.0, which is set before 0.49.0.0.49.0
https://github.com/chakra-ui/zag/blob/%40zag-js/popover%400.49.0/packages/machines/popover/src/popover.machine.ts#L228
0.50.0
https://github.com/chakra-ui/zag/blob/%40zag-js/popover%400.50.0/packages/machines/popover/src/popover.machine.ts#L230
The popover content does not look place right position just after opening,
setInitialFocuswill cause this timing, so I think we still need{ preventScroll: true }parameter.⛳️ Current behavior (updates)
The popover component will reset scroll position when it is opened.
🚀 New behavior
The popover component DOES NOT reset scroll position when it is opened.
💣 Is this a breaking change (Yes/No):
No
📝 Additional Information