Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MinSdk to 21 #3

Closed
wakaztahir opened this issue May 13, 2023 · 5 comments
Closed

MinSdk to 21 #3

wakaztahir opened this issue May 13, 2023 · 5 comments

Comments

@wakaztahir
Copy link

wakaztahir commented May 13, 2023

Jetpack Compose min sdk version is 21 and this library should also support min sdk version 21

The library is also missing functions like push and pop , I created my own push by using duplicate Strategy of Add to Stack

Could you please fix this fast , My app is currntnly increasing its min SDK version to be able to use this library

@github-actions
Copy link

Welcome and thanks for contributing! Make sure to leave a detailed explanation of the issue.

@wakaztahir
Copy link
Author

please update

@chRyNaN
Copy link
Owner

chRyNaN commented May 22, 2023

Thanks for bringing this up, I will address this in the upcoming release. I am finishing up tests and hope to have the release out this week.

@chRyNaN
Copy link
Owner

chRyNaN commented May 22, 2023

As for push/pop functionality, those are provided by the goTo/goBack functions on the Navigator instance. The goTo function acts as a "push" stack operation and the goBack function can act as a "pop" stack operation (although it can be more complex as there is the notion of "contexts").

@chRyNaN
Copy link
Owner

chRyNaN commented May 23, 2023

The minimum Android version has been lowered to 21 with the latest release: https://github.com/chRyNaN/navigation/releases/tag/0.8.0

@chRyNaN chRyNaN closed this as completed May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants