From 89c27f1604d13a78f6e677f6a8136e69abb1c728 Mon Sep 17 00:00:00 2001
From: Chris Keenan <chrynan@pm.me>
Date: Mon, 22 May 2023 10:45:00 -0500
Subject: [PATCH] Lowered min Android version to 21

---
 .../LibraryConstants.kt                             |  2 +-
 navigation-core/build.gradle.kts                    |  8 +++++++-
 .../navigation/NavigationContextStacksTest.kt       | 13 +++++++++----
 3 files changed, 17 insertions(+), 6 deletions(-)

diff --git a/buildSrc/src/main/java/com.chrynan.navigation.buildSrc/LibraryConstants.kt b/buildSrc/src/main/java/com.chrynan.navigation.buildSrc/LibraryConstants.kt
index 2d87a68..0d79b92 100644
--- a/buildSrc/src/main/java/com.chrynan.navigation.buildSrc/LibraryConstants.kt
+++ b/buildSrc/src/main/java/com.chrynan.navigation.buildSrc/LibraryConstants.kt
@@ -16,7 +16,7 @@ object LibraryConstants {
     object Android {
 
         const val compileSdkVersion = 33
-        const val minSdkVersion = 23
+        const val minSdkVersion = 21
         const val targetSdkVersion = 33
     }
 }
diff --git a/navigation-core/build.gradle.kts b/navigation-core/build.gradle.kts
index 83a6f62..bd6778a 100644
--- a/navigation-core/build.gradle.kts
+++ b/navigation-core/build.gradle.kts
@@ -24,7 +24,13 @@ kotlin {
         jvm()
 
         js(IR) {
-            browser()
+            browser {
+                testTask {
+                    useKarma {
+                        useFirefox()
+                    }
+                }
+            }
             nodejs()
         }
 
diff --git a/navigation-core/src/commonTest/kotlin/com/chrynan/navigation/NavigationContextStacksTest.kt b/navigation-core/src/commonTest/kotlin/com/chrynan/navigation/NavigationContextStacksTest.kt
index 390bccb..55be731 100644
--- a/navigation-core/src/commonTest/kotlin/com/chrynan/navigation/NavigationContextStacksTest.kt
+++ b/navigation-core/src/commonTest/kotlin/com/chrynan/navigation/NavigationContextStacksTest.kt
@@ -85,7 +85,8 @@ internal class NavigationContextStacksTest {
 
         assertEquals(expected = 2, actual = stack.size)
         assertEquals(expected = TestDestination.CHANNEL_DETAILS, actual = stack.peek())
-        assertEquals(expected = TestDestination.FAVORITES, actual = stack.first())
+        assertEquals(expected = TestDestination.CHANNEL_DETAILS, actual = stack.first())
+        assertEquals(expected = TestDestination.FAVORITES, actual = stack.last())
     }
 
     @Test
@@ -111,14 +112,18 @@ internal class NavigationContextStacksTest {
 
         assertEquals(expected = 2, actual = stack.size)
         assertEquals(expected = TestDestination.ITEM_DETAILS, actual = stack.peek())
-        assertEquals(expected = TestDestination.HOME, actual = stack.first())
+        assertEquals(expected = TestDestination.ITEM_DETAILS, actual = stack.first())
+        assertEquals(expected = TestDestination.HOME, actual = stack.last())
     }
 
     @Test
-    fun pushAllAddsItemsToTopOfStack(){
+    fun pushAllAddsItemsToTopOfStack() {
         val stacks = NavigationContextStacks<TestDestination, TestContext>(initialContext = TestContext.Home)
 
-        stacks.pushAll(context = TestContext.Home, destinations = stackOf(TestDestination.ITEM_DETAILS, TestDestination.FAVORITES))
+        stacks.pushAll(
+            context = TestContext.Home,
+            destinations = stackOf(TestDestination.ITEM_DETAILS, TestDestination.FAVORITES)
+        )
 
         val stack = stacks[TestContext.Home].toMutableStack()