Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom constraints can't be implemented without access to make_cgreen_<type>_value() #266

Open
thoni56 opened this issue Jun 17, 2021 · 1 comment
Labels
Milestone

Comments

@thoni56
Copy link
Contributor

thoni56 commented Jun 17, 2021

The feature of being able to create custom constraints (see https://cgreen-devs.github.io/#_custom_constraints) is very handy.

However the example, and use, requires the inclusion of cgreen_value_internal.h which is not available in a packaged installation, so you need to have the source available.

One way to fix this is to move cgreen_value_internal.h to include/cgreen/internal/cgreen_value_internal.h. This way it would be available in packaged installations, but also clearly signal that using this is subject to some risk.

@thoni56 thoni56 added the bug label Jun 17, 2021
@thoni56 thoni56 added this to the 1.5.0 milestone Jun 17, 2021
@thoni56 thoni56 changed the title Custom constraints can't be implemented without access to create_cgreen_<type>_value() Custom constraints can't be implemented without access to make_cgreen_<type>_value() Jun 17, 2021
@thoni56
Copy link
Contributor Author

thoni56 commented Jun 17, 2021

The example also shouldn't` indicate that you should (or even can) access Cgreen's internal functions...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant