Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credentials embedded in destination URLs exposed in the dashboard #5

Open
thebe14 opened this issue Jan 18, 2023 · 2 comments
Open

Comments

@thebe14
Copy link

thebe14 commented Jan 18, 2023

If I create a transfer where the destination URLs include a username/password (e.g. ftp:https://username:[email protected]/path/file.zip) then the credentials are exposed in the FTS dashboard, as the full URL is shown there. The dashboard must strip the credentials from the URLs. This is a very serious security vulnerability.

@mpatrascoiu

@mpatrascoiu
Copy link
Contributor

I'm not sure I would go on to call this a security vulnerability.

FTS openly claims whatever is in the URL is treated as public data. FTS is also protocol agnostic (for the better part), so it won't treat an ftp:https:// transfer submission differently than an https:// transfer submission.

The actual storage interaction is delegated to the Gfal2 library. Here, there is a mechanism to configure a username/password credential for FTP protocol.

Perhaps you're asking for a feature that doesn't exist yet in FTS: identify and extract user credentials from URL at submission time.

@thebe14
Copy link
Author

thebe14 commented Jan 19, 2023

Salut Mihai,

I tried to transfer to a FTP server using FTS, and it does not work unless the FTP server accepts anonymous operations (this is indeed a feature request, but I will create another issue for it). I do not know of any other mechanism to supply the credentials for these FTP destinations than to embed them in the URL.

I understand FTS has this disclaimer that whatever is in the URL is treated as public data. But if FTP is to be supported, this has to change.

Cele bune,
Levente

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants