Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all docstrings #618

Open
kerimoyle opened this issue Jun 8, 2020 · 1 comment
Open

Fix all docstrings #618

kerimoyle opened this issue Jun 8, 2020 · 1 comment

Comments

@kerimoyle
Copy link
Contributor

Just a general note that I've noticed a function description that's not quite true, and there are probably others ...
(a UnitsPtr is not the name, it's the pointer ...)

    /**
     * @brief Get the name of the units for this variable.
     *
     * Get the name of the units for this variable. If no units are set
     * an empty @c std::string is returned.
     *
     * @sa setUnits
     * @sa removeUnits
     *
     * @return The @c UnitsPtr of the units for this variable.
     */
    UnitsPtr units() const;
@kerimoyle kerimoyle changed the title Make sure docstrings are truthful ... Fix all docstrings Jul 23, 2020
@kerimoyle
Copy link
Contributor Author

We also need to make a schema for docstrings and follow it:

  • when referencing a parameter, we use the @p prefix and the actual variable name (not the description of the parameter)?
  • when referencing an object that has a pointer, do we use the pointer type or the pointed-to type? ie: when passing a model to the printer, should it be discussed as a @c ModelPtr or a @c Model or just a model?
  • when just talking about the conceptual thing rather than the code-representation, should we be using any kind of markup at all?
  • how do we talk about null pointers?
  • how do we talk about the range of vectors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant