-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overload "equivalent" units methods to return info if required #548
Comments
I guess it could be useful to some, so sure. |
I think it would be more in keeping with the way things are working to have a tool that reported on the equivalence of two units, without recourse to using a model. |
What do you mean by tool? |
Here's what I'm imagining:
|
A class like the |
I guess this is related to our phone conversation @hsorby ? A more generic |
Hmm ... would the current |
I'm definitely not happy to leave it as |
No I don't have a good name for such a tool. |
Currently we only return true/false from the
Units::equivalent
family of methods. I think it would be really useful to overload these to return the error message via the argument list so that people can import units and test them for equivalence without having to first create a model, assign connected variables etc etc just in order to get the mismatch information message. Thoughts?The text was updated successfully, but these errors were encountered: