Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need to validate strings representing real numbers in CellML initial_values? #291

Open
kerimoyle opened this issue Mar 26, 2019 · 3 comments

Comments

@kerimoyle
Copy link
Contributor

We currently don't validate that the occurrences of real numbers in the CellML2.0 model:

  • 11.1.2.2 Variable -> Initial_values
  • 9.1.2.2 Unit -> Multiplier
  • 9.1.2.3 Unit -> Exponent
@kerimoyle
Copy link
Contributor Author

kerimoyle commented Mar 27, 2019

Whoops, yes it does, just not in the validator struct. Real numbers are checked for the multipliers and exponents when they're read by the parser, but intial_value attributes are stored naively as strings: is that the intention?

@kerimoyle kerimoyle changed the title Validate strings representing real numbers in CellML elements Do we need to validate strings representing real numbers in CellML initial_values? Mar 27, 2019
@nickerso
Copy link
Contributor

initial_value attributes can be either a number or a variable name, so I think we store it as a string so that we can always determine which it is...there should be validation that checks the string is either a variable in the same component or a valid real number.

@kerimoyle
Copy link
Contributor Author

OK, ta, I'll add that to the list :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants