Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage statistics link on https://libcellml.readthedocs.io is broken #148

Open
PrasadBabarendaGamage opened this issue Mar 12, 2017 · 3 comments
Assignees

Comments

@PrasadBabarendaGamage
Copy link

The coverage statistics link on https://libcellml.readthedocs.io/en/latest/coverage_statistics.html is broken. It currently points to: https://libcellml.readthedocs.io/en/latest/coverage/index.html which gives a "sorry this page does not exist yet" message.

The text in the 'note' on https://libcellml.readthedocs.io/en/latest/coverage_statistics.html also needs to be updated from:
The coverage test sometimes (this behaviour has been observed on OS X using clang) reports single lines containing only a closing curly brace as not covered.
to:
The coverage test sometimes eports single lines containing only a closing curly brace as not covered (this behaviour has been observed on OS X using clang).

@nickerso
Copy link
Contributor

Thanks @PrasadBabarendaGamage. That link currently only works if you build the docs yourself and have coverage stats available, such as is available on the buildbot generated docs (https://autotest.bioeng.auckland.ac.nz/libcellml-buildbot/c842463cd24465354631fb1ef867f009e1d92fbd/dox/coverage_statistics.html). We hope to one day have the CI system integrate this information into the readthedocs generated docs, and hence leave the "broken" link in the docs...

As for the correction, I'm not sure I agree :) Will have to see what @hsorby thinks of it...

@hsorby
Copy link
Contributor

hsorby commented Mar 12, 2017

This issue is listed under #41, I am ok with the change but would prefer to use the word 'reports' instead of 'eports'.

@hsorby
Copy link
Contributor

hsorby commented Aug 16, 2018

Working on getting readthedocs to be able to include the coverage reports. If I can get readthedocs to add SWIG to the latest Docker image for building then I think we can make this happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants