Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: rename the generator files/folders to generator_interpreter #1221

Open
agarny opened this issue Apr 7, 2024 · 0 comments
Open

Tests: rename the generator files/folders to generator_interpreter #1221

agarny opened this issue Apr 7, 2024 · 0 comments
Assignees

Comments

@agarny
Copy link
Contributor

agarny commented Apr 7, 2024

This is to be done once issue #1218 has been addressed. For that issue, we want to rely on our generator tests (to ensure that we cover the same cases for our interpreter). This means we should then rename those generator files/folders to generator_interpreter so that it's clear that they are for both our generator and interpreter, and not only our generator.

We could do it as part of issue #1218 but then we would end up with hundreds of files being added/deleted, making the reviewing process unnecessarily difficult. By doing this in a dedicated issue, the reviewing process will very easy since no new functionality will be added. So, as long as the tests pass, we will be all good.

@agarny agarny self-assigned this Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant