Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to interpret a model (initially algebraic and ODE models) #1220

Open
wants to merge 90 commits into
base: main
Choose a base branch
from

Conversation

agarny
Copy link
Contributor

@agarny agarny commented Apr 7, 2024

Fixes #1218.

@agarny agarny force-pushed the issue1218 branch 7 times, most recently from 1f42143 to 8b24d99 Compare April 8, 2024 07:04
@agarny agarny force-pushed the issue1218 branch 5 times, most recently from 6195eff to 0c80224 Compare April 8, 2024 12:05
@hsorby hsorby added the New feature Additional feature label Apr 8, 2024
@agarny agarny force-pushed the issue1218 branch 2 times, most recently from ac14aa0 to 1ec290b Compare April 9, 2024 03:32
@agarny agarny force-pushed the issue1218 branch 3 times, most recently from 54652a2 to 79df1ec Compare April 10, 2024 23:50
@agarny agarny force-pushed the issue1218 branch 7 times, most recently from 85611e0 to c8eec99 Compare April 24, 2024 02:53
Indeed, it is 15 to 20 times slower than the AST-based interpreter. Clearly, handling a stack is more costly than handling recursion.
This was only done to check that we do indeed get the same results... and we do.
Very important to make sure that we do indeed get the results we expect for all aspects of the interpreter.
@agarny agarny force-pushed the issue1218 branch 3 times, most recently from 0695749 to 35ef7c2 Compare April 24, 2024 06:30
agarny and others added 8 commits April 26, 2024 01:01
Rather than `std::vector<double>` (and then retrieve the data using `data()`. Indeed, some solvers may want to use temporary arrays (e.g., CVODE uses a temporary array of doubles for states and rates), which means that we need to be able to set them, if needed.
We now rely on the user providing them since some solvers may use temporary arrays to compute rates (e.g., CVODE uses temporary arrays for states and rates).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New feature Additional feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it possible to interpret a model (initially algebraic and ODE models)
3 participants