Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analyser: improve the reporting of unit-related issues with the pow() function #1212

Merged
merged 15 commits into from
Mar 27, 2024
Merged

Analyser: improve the reporting of unit-related issues with the pow() function #1212

merged 15 commits into from
Mar 27, 2024

Conversation

agarny
Copy link
Contributor

@agarny agarny commented Mar 5, 2024

Fixes #1211.

@hsorby hsorby added the Analyser label Mar 6, 2024
hsorby
hsorby previously approved these changes Mar 24, 2024
View reviewed changes
@agarny agarny requested a review from nickerso March 24, 2024 21:26
hsorby
hsorby reviewed Mar 27, 2024
View reviewed changes
src/generator_p.h Outdated Show resolved Hide resolved
@agarny
Generator: isolated the generateDoubleCode() function.
35c8b0c 
So that we don't need to make `Analyser` a friend class of `Generator`.
@agarny
Analyser: removed a redundant check.
279a7d4 
... which made our code coverage fail.
@agarny agarny requested a review from hsorby March 27, 2024 03:14
@agarny
Copy link
Contributor Author

agarny commented Mar 27, 2024

@hsorby and @nickerso: ready to be re-reviewed. FWIW, yesterday, we talked about adding a reference rule, but I don't think there is a need for that. There is already a special reference rule (Issue::ReferenceRule::ANALYSER_UNITS) for all units-related issues found by the analyser.

@agarny agarny merged commit a788603 into cellml:main Mar 27, 2024
11 checks passed
@agarny agarny deleted the issue1211 branch March 27, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsorby hsorby hsorby approved these changes

@nickerso nickerso nickerso approved these changes

Assignees
No one assigned
Labels
Analyser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Analyser: improve the reporting of unit-related issues with the pow() function
3 participants
@agarny @hsorby @nickerso