Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the segfault when resolving imports #1204

Merged
merged 7 commits into from
Nov 13, 2023
Merged

Fix the segfault when resolving imports #1204

merged 7 commits into from
Nov 13, 2023

Conversation

hsorby
Copy link
Contributor

@hsorby hsorby commented Nov 13, 2023

The model::hasUnresolvedImports() method can segfault if an imported component has units used in the math that are not defined in the model the component is from. This work fixes #1203.

@hsorby hsorby added the Imports label Nov 13, 2023
@hsorby hsorby requested a review from agarny November 13, 2023 20:15
agarny
agarny reviewed Nov 13, 2023
View reviewed changes
Copy link
Contributor

@agarny agarny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment, otherwise looks good to me.

src/internaltypes.h Show resolved Hide resolved
@agarny agarny merged commit a650881 into cellml:main Nov 13, 2023
11 checks passed
@hsorby hsorby deleted the segfault-resolving-imports branch November 13, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agarny agarny agarny approved these changes

@nickerso nickerso nickerso approved these changes

Assignees
No one assigned
Labels
Imports
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Another issue with units
3 participants
@hsorby @agarny @nickerso