-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we broaden analyser checks for overconstrained connected variables #1162
Comments
I am not personally in favour of it. This would encourage bad practice. |
Its not always bad practice...imagine a model that imports a component with parameter values embedded in the initial values. Might be nice to be able to override them by providing initial values in the importing model. But I actually think this would require a spec change to specify the precedence of initial values so that it is reproducible for a given model what is the initial value for a connected variable set. |
My question above is about when the initial value is set to the same value, this to me doesn't make the system overconstrained. Deciding which initial value should be dominant because they are different seems to me to be a separate issue. |
The analyser tells me that
But they are initialised to the same value so I don't think that this should be an error.
Originally posted by @hsorby in #942 (comment)
The text was updated successfully, but these errors were encountered: