-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add base64 dependency to gemspec or inline implementation #401
Comments
olleolleolle
added a commit
to olleolleolle/webauthn-ruby
that referenced
this issue
Sep 22, 2023
This avoids a warning emitted by Ruby 3.3.0-preview2. Fixes cedarcode#401.
olleolleolle
added a commit
to olleolleolle/webauthn-ruby
that referenced
this issue
Oct 13, 2023
This avoids a warning emitted by Ruby 3.3.0-preview2. Fixes cedarcode#401.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Starting in Ruby 3.3.0-preview2, requiring webauthn warns:
base64
will move from a standard library gem to a bundled gem in Ruby 3.4.0. That will break applications using bundler and webauthn unless webauthn declares a dependency onbase64
or inlines the necessary implementation. Note thatbase64
was not gemified until Ruby 3.0, but the currentbase64
gem supports Ruby 2.3.0+, so this should not cause backwards compatibility issues.In my own libraries, I've chosen to inline the implementation, as
base64
is a thin wrapper aroundString#unpack1
andArray#pack
.The text was updated successfully, but these errors were encountered: