Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base64 dependency to gemspec or inline implementation #401

Closed
jeremyevans opened this issue Sep 18, 2023 · 0 comments · Fixed by #402
Closed

Add base64 dependency to gemspec or inline implementation #401

jeremyevans opened this issue Sep 18, 2023 · 0 comments · Fixed by #402

Comments

@jeremyevans
Copy link

Starting in Ruby 3.3.0-preview2, requiring webauthn warns:

$ ruby33 -r webauthn -e ''
/usr/local/lib/ruby/gems/3.3/gems/webauthn-3.0.0/lib/webauthn/encoder.rb:3: warning: base64 which will be not part of the default gems since Ruby 3.4.0

base64 will move from a standard library gem to a bundled gem in Ruby 3.4.0. That will break applications using bundler and webauthn unless webauthn declares a dependency on base64 or inlines the necessary implementation. Note that base64 was not gemified until Ruby 3.0, but the current base64 gem supports Ruby 2.3.0+, so this should not cause backwards compatibility issues.

In my own libraries, I've chosen to inline the implementation, as base64 is a thin wrapper around String#unpack1 and Array#pack.

olleolleolle added a commit to olleolleolle/webauthn-ruby that referenced this issue Sep 22, 2023
This avoids a warning emitted by Ruby 3.3.0-preview2.

Fixes cedarcode#401.
olleolleolle added a commit to olleolleolle/webauthn-ruby that referenced this issue Oct 13, 2023
This avoids a warning emitted by Ruby 3.3.0-preview2.

Fixes cedarcode#401.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant