Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider providing a conversion of Credential Options to JSON ready to call WebAuthn API #185

Closed
grzuy opened this issue Apr 29, 2019 · 1 comment · Fixed by #255
Closed

Consider providing a conversion of Credential Options to JSON ready to call WebAuthn API #185

grzuy opened this issue Apr 29, 2019 · 1 comment · Fixed by #255
Labels
area: authentication initiation area: registration initiation type: feature request
Milestone
v2.0

Comments

@grzuy
Copy link
Contributor

grzuy commented Apr 29, 2019

No description provided.

This was referenced Apr 29, 2019
Merged
Closed
@grzuy
Copy link
Contributor Author

grzuy commented Aug 20, 2019 •
edited

Thinking maybe something like...

WebAuthn::PublicKeyCredential.create_options(encoding: :base64url, ...)
WebAuthn::PublicKeyCredential.get_options(encoding: :base64url, ...)

could play well with the new

WebAuthn::PublicKeyCredential.from_create
WebAuthn::PublicKeyCredential.from_get

methods we have now.

@grzuy grzuy mentioned this issue Aug 23, 2019
Merged
@grzuy grzuy added this to the v2.0 milestone Sep 2, 2019
@grzuy grzuy closed this as completed in #255 Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: authentication initiation area: registration initiation type: feature request
Projects
None yet
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

feat: improve credential options cedarcode/webauthn-ruby
1 participant
@grzuy