Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make fake authenticator available in the library #100

Closed
lgarron opened this issue Oct 26, 2018 · 2 comments · Fixed by #101
Closed

Make fake authenticator available in the library #100

lgarron opened this issue Oct 26, 2018 · 2 comments · Fixed by #101
Labels
area: fake client type: feature request

Comments

@lgarron
Copy link
Contributor

lgarron commented Oct 26, 2018

The spec folder has a fake authenticator implementation. I've had trouble extracting that code and getting it working for testing our backend.
. (At themoment

Would it be possible to expose this fake authenticator for testing, with about the convenience of https://github.com/castle/ruby-u2f/blob/a525e7aad75f72ccd122b135b1b9676a427d5f68/lib/u2f/fake_u2f.rb ?
@grzuy
Copy link
Contributor

grzuy commented Oct 27, 2018 •
edited
Loading

Hi @lgarron,

Yes, sounds good to me.
Apart from moving it to the lib folder we need additional changes to decouple it from some of the fake_* methods in spec/spec_helper.rb.

@grzuy grzuy mentioned this issue Oct 30, 2018
Merged
@grzuy
Copy link
Contributor

grzuy commented Nov 1, 2018

This is available in v1.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: fake client type: feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: make FakeAuthenticator avialable to require and used outside of tests cedarcode/webauthn-ruby
2 participants
@lgarron @grzuy