Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cedarcode/webauthn-ruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.0.0
Choose a base ref
...
head repository: cedarcode/webauthn-ruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.1.0
Choose a head ref
  • 13 commits
  • 10 files changed
  • 6 contributors

Commits on Sep 13, 2018

  1. Configuration menu
    Copy the full SHA
    85f69dd View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2018

  1. feat: Make methods public to expose data available

    Current implementation hides many data available from authenticators
    behind the private methods. It is useful to expose them to users of this
    gem, i.e. logging, auditing, and debugging.
    
    I believe this gem should provide a low-level API for RP
    implementations.
    sorah committed Oct 1, 2018
    Configuration menu
    Copy the full SHA
    9b08942 View commit details
    Browse the repository at this point in the history
  2. feat: Parse signCount on AuthenticatorData

    To allow RP to check signature count mismatch
    
    https://www.w3.org/TR/2018/CR-webauthn-20180807/#sign-counter
    sorah committed Oct 1, 2018
    Configuration menu
    Copy the full SHA
    80b3667 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    509c6dc View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2018

  1. refactor: make AttestedCredentialData::Credential a Struct

    OpenStruct doesn't need any attributes to be declared beforehand. But
    this reduces readability, even all attributes used are known.
    
    We have to stop using keyword arguments to initialize Credential struct,
    but we can back later once we dropped Ruby 2.4 support by Struct `:keyword_init`.
    sorah committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    fe710cc View commit details
    Browse the repository at this point in the history
  2. feat: Accept rp_id explicitly on *Response#valid?

    Closes #72
    
    RP ID may be different from request origin; i.e. client may override,
    or the appid extension may give legacy app id as a RP ID.
    
    In most cases, rp_id can be expected to be a host part of request origin
    URI. So this patch allows `valid?` methods to take optional `rp_id`, then the
    methods handle the explicitly given one as a RP ID, instead of a host of
    origin URI, when it's given.
    sorah committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    92a5684 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #71 from sorah/struct-cred

    refactor: make AttestedCredentialData::Credential a Struct
    brauliomartinezlm authored Oct 2, 2018
    Configuration menu
    Copy the full SHA
    f131a1e View commit details
    Browse the repository at this point in the history
  4. Merge pull request #69 from sorah/public

    feat: Make methods public to expose data available
    grzuy authored Oct 2, 2018
    Configuration menu
    Copy the full SHA
    b7e26e0 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2018

  1. Configuration menu
    Copy the full SHA
    51711c8 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #70 from sorah/sign_count

    Parse signCount and expose at AuthenticatorData#sign_count
    brauliomartinezlm authored Oct 3, 2018
    Configuration menu
    Copy the full SHA
    abd0d15 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7fd00a9 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #77 from lgarron/publick_key

    docs: Fix functional typo in `README.md`: publick_key -> public_key.
    brauliomartinezlm authored Oct 3, 2018
    Configuration menu
    Copy the full SHA
    a695941 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2018

  1. Merge pull request #73 from sorah/rp_id

    feat: Accept rp_id explicitly on *Response#valid?
    brauliomartinezlm authored Oct 4, 2018
    Configuration menu
    Copy the full SHA
    b1e952f View commit details
    Browse the repository at this point in the history
Loading