-
Notifications
You must be signed in to change notification settings - Fork 55
Comparing changes
Open a pull request
base repository: cedarcode/webauthn-ruby
base: v1.0.0
head repository: cedarcode/webauthn-ruby
compare: v1.1.0
- 13 commits
- 10 files changed
- 6 contributors
Commits on Sep 13, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 85f69dd - Browse repository at this point
Copy the full SHA 85f69ddView commit details
Commits on Oct 1, 2018
-
feat: Make methods public to expose data available
Current implementation hides many data available from authenticators behind the private methods. It is useful to expose them to users of this gem, i.e. logging, auditing, and debugging. I believe this gem should provide a low-level API for RP implementations.
Configuration menu - View commit details
-
Copy full SHA for 9b08942 - Browse repository at this point
Copy the full SHA 9b08942View commit details -
feat: Parse signCount on AuthenticatorData
To allow RP to check signature count mismatch https://www.w3.org/TR/2018/CR-webauthn-20180807/#sign-counter
Configuration menu - View commit details
-
Copy full SHA for 80b3667 - Browse repository at this point
Copy the full SHA 80b3667View commit details -
Configuration menu - View commit details
-
Copy full SHA for 509c6dc - Browse repository at this point
Copy the full SHA 509c6dcView commit details
Commits on Oct 2, 2018
-
refactor: make AttestedCredentialData::Credential a Struct
OpenStruct doesn't need any attributes to be declared beforehand. But this reduces readability, even all attributes used are known. We have to stop using keyword arguments to initialize Credential struct, but we can back later once we dropped Ruby 2.4 support by Struct `:keyword_init`.
Configuration menu - View commit details
-
Copy full SHA for fe710cc - Browse repository at this point
Copy the full SHA fe710ccView commit details -
feat: Accept rp_id explicitly on *Response#valid?
Closes #72 RP ID may be different from request origin; i.e. client may override, or the appid extension may give legacy app id as a RP ID. In most cases, rp_id can be expected to be a host part of request origin URI. So this patch allows `valid?` methods to take optional `rp_id`, then the methods handle the explicitly given one as a RP ID, instead of a host of origin URI, when it's given.
Configuration menu - View commit details
-
Copy full SHA for 92a5684 - Browse repository at this point
Copy the full SHA 92a5684View commit details -
Merge pull request #71 from sorah/struct-cred
refactor: make AttestedCredentialData::Credential a Struct
Configuration menu - View commit details
-
Copy full SHA for f131a1e - Browse repository at this point
Copy the full SHA f131a1eView commit details -
Merge pull request #69 from sorah/public
feat: Make methods public to expose data available
Configuration menu - View commit details
-
Copy full SHA for b7e26e0 - Browse repository at this point
Copy the full SHA b7e26e0View commit details
Commits on Oct 3, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 51711c8 - Browse repository at this point
Copy the full SHA 51711c8View commit details -
Merge pull request #70 from sorah/sign_count
Parse signCount and expose at AuthenticatorData#sign_count
Configuration menu - View commit details
-
Copy full SHA for abd0d15 - Browse repository at this point
Copy the full SHA abd0d15View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7fd00a9 - Browse repository at this point
Copy the full SHA 7fd00a9View commit details -
Merge pull request #77 from lgarron/publick_key
docs: Fix functional typo in `README.md`: publick_key -> public_key.
Configuration menu - View commit details
-
Copy full SHA for a695941 - Browse repository at this point
Copy the full SHA a695941View commit details
Commits on Oct 4, 2018
-
Merge pull request #73 from sorah/rp_id
feat: Accept rp_id explicitly on *Response#valid?
Configuration menu - View commit details
-
Copy full SHA for b1e952f - Browse repository at this point
Copy the full SHA b1e952fView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.0.0...v1.1.0