Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exclude should be excludeCredentials #126

Closed
pedz opened this issue Nov 20, 2022 · 1 comment
Closed

exclude should be excludeCredentials #126

pedz opened this issue Nov 20, 2022 · 1 comment

Comments

@pedz
Copy link

pedz commented Nov 20, 2022

Should line 10 of credential_controller be excludeCredentials?

Also, it should be a list of PublicKeyCredentialDescriptor which should also include the type.

I thought maybe the webauthn-json might be fixing things up for you but I don't see it.
@pedz
Copy link
Author

pedz commented Nov 22, 2022

I see now... webauthn-ruby converts the exclude list into an excludeCredentials list.

@pedz pedz closed this as completed Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pedz