Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Awards for Managers and Players don't appear to be updated #60

Open
jestarr opened this issue Feb 19, 2021 · 2 comments
Open

Awards for Managers and Players don't appear to be updated #60

jestarr opened this issue Feb 19, 2021 · 2 comments
Assignees
Labels

Comments

@jestarr
Copy link

jestarr commented Feb 19, 2021

It looks like both Awards tables need to be updated.

library(tidyverse)
packageVersion("Lahman")
#> [1] '8.0.1'

Lahman::AwardsManagers %>% 
  .$yearID %>% 
  max()
#> [1] 2016


Lahman::AwardsPlayers %>% 
  .$yearID %>% 
  max()
#> [1] 2017
@friendly
Copy link
Collaborator

Thx @jestarr
The Lahman package is approaching its annual update time to include more recent data and updates. We'll look at this.

We always lag behind Sean Lahman's database because that is our official source and we do not contemplate updating our data files beyond Lahman in a given cycle

@cdalzell
Copy link
Owner

I took a quick look at the source data from both last year as well as what's coming this year and it does indeed look like those are the most recent years in both tables.

I'll take a deeper look when I start the update here soon.

@cdalzell cdalzell self-assigned this Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants