Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promise.all #5

Closed
jdgamble555 opened this issue Nov 16, 2022 · 1 comment · Fixed by #6
Closed

promise.all #5

jdgamble555 opened this issue Nov 16, 2022 · 1 comment · Fixed by #6

Comments

@jdgamble555
Copy link

You should probably use batch here (and in other places) instead of Promise.all.

await Promise.all([

Great clone btw!

J

@ccrsxx
Copy link
Owner

ccrsxx commented Nov 16, 2022

Thanks for noticing that. I think using batch would be much cleaner. I'll see what I can do later!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants