Images should not be indexed on alt, but rather unique id

[stanbar]

Hi,
I believe that storing images based on the alt is not an good idea and instead unique id should be used. The reason is that, uploading two images with the same filename (thus the same alts), replaces the previous image.

Instead of

twitter-clone/src/lib/firebase/utils.ts

Line 139 in c6bf6fb

const storageRef = ref(storage, `images/${userId}/${alt}`);

I would rather use

const storageRef = ref(storage, `images/${userId}/${id}`);

[Ketchupchh]

Yeah, this should be fixed. In my testing it doesn't replace any images but just discards the new one and places the original in the tweet instead. I'll fix the issues you found in my PR as well, thank you. I'll contact ccrsxx about the username bug as well.

[stanbar]

@Ketchupchh thank you!

[ccrsxx]

Yup, but that's by design.

I made it so that when we upload the same image with the same alt, it will return the old image instead of creating the new image. It won't replace the old image with the new image tho.

This is the code:

twitter-clone/src/lib/firebase/utils.ts

Lines 141 to 146 in c6bf6fb

	try {
	src = await getDownloadURL(storageRef);
	} catch {
	await uploadBytesResumable(storageRef, file);
	src = await getDownloadURL(storageRef);
	}

I did it to reduce the bandwidth usage on the storage.

But yeah, that's bad if you upload a different picture with the same alt, it'll return the old one.

I see that the bandwidth usage isn't that much, so I think replacing the alt to id is good idea now.

[stanbar]

@ccrsxx Well, if you want to do this kind of optimisation I think that the better option would be to calculate a hash (e.g. sha256) of a file's content, and use that instead of a filename. That way, the same images with different names, would be stored only once.

[ccrsxx]

Yup, that could be the solution. But for now, I''ll be using the randomly generated id.

[ccrsxx]

Fixed in #40