Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @Paparazzi KotlinPoet codegen #1545

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Add @Paparazzi KotlinPoet codegen #1545

wants to merge 10 commits into from

Conversation

geoff-powell
Copy link
Collaborator

@geoff-powell geoff-powell commented Aug 21, 2024 •
edited
Loading

Adds codegen to look for @Paparazzi previews and create a manifest file to use them in tests.

@geoff-powell geoff-powell marked this pull request as ready for review August 26, 2024 16:00
@geoff-powell geoff-powell force-pushed the akent/simple-preview/processor branch 2 times, most recently from f09b160 to eb91f48 Compare August 27, 2024 14:05
@geoff-powell geoff-powell force-pushed the akent/simple-preview/processor branch 2 times, most recently from 71e0f92 to b40641a Compare August 27, 2024 15:52
Base automatically changed from akent/simple-preview/api to master August 28, 2024 14:28
jrodbx
jrodbx requested changes Aug 29, 2024
View reviewed changes
...zzi-preview-processor/src/main/java/app/cash/paparazzi/preview/processor/PreviewProcessor.kt Show resolved Hide resolved
...zzi-preview-processor/src/main/java/app/cash/paparazzi/preview/processor/PreviewProcessor.kt Outdated Show resolved Hide resolved
paparazzi-preview-processor/src/main/java/app/cash/paparazzi/preview/processor/Utils.kt Outdated Show resolved Hide resolved
paparazzi-preview-processor/src/main/java/app/cash/paparazzi/preview/processor/Utils.kt Outdated Show resolved Hide resolved
...zzi-preview-processor/src/main/java/app/cash/paparazzi/preview/processor/PreviewProcessor.kt Show resolved Hide resolved
paparazzi-preview-processor/src/main/java/app/cash/paparazzi/preview/processor/PaparazziPoet.kt Outdated Show resolved Hide resolved
@jrodbx jrodbx changed the title Add @Papaprazzi KotlinPoet codegen Add @Paparazzi KotlinPoet codegen Aug 29, 2024
@geoff-powell geoff-powell force-pushed the akent/simple-preview/processor branch 5 times, most recently from 6d4a21b to 5f18f8c Compare September 3, 2024 16:52
BrianGardnerAtl
BrianGardnerAtl approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@BrianGardnerAtl BrianGardnerAtl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding all the tests! It really helps grok how everything works together

gamepro65
gamepro65 approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@gamepro65 gamepro65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrodbx jrodbx jrodbx requested changes

@nak5ive nak5ive nak5ive approved these changes

@BrianGardnerAtl BrianGardnerAtl BrianGardnerAtl approved these changes

@gamepro65 gamepro65 gamepro65 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@geoff-powell @nak5ive @BrianGardnerAtl @gamepro65 @jrodbx